Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mpas-seaice for snicar and snow grain model #3058

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Update mpas-seaice for snicar and snow grain model #3058

merged 2 commits into from
Aug 13, 2019

Conversation

jonbob
Copy link
Contributor

@jonbob jonbob commented Jul 11, 2019 •
edited by rljacob

This PR brings in a new mpas-source submodule that only updates the mpas-seaice code, as well as the supporting scripts to match. The seaice has changes to:

Because these features are off by default, this PR is BFB but does have a namelist change.

[NML]
[BFB]

@jonbob jonbob added mpas-seaice BFB PR leaves answers BFB NML labels Jul 11, 2019
@jonbob jonbob added this to the v2.0alpha milestone Jul 11, 2019
@jonbob jonbob self-assigned this Jul 11, 2019
@jonbob jonbob changed the title Update mpas-source submodule to get new version of mpas-seaice plus s… Update mpas-seaice for snicar and snow grain model Jul 11, 2019
@rljacob
Copy link
Member

rljacob commented Jul 25, 2019 •
edited

The SNICAR part his covered by this code review document:
https://acme-climate.atlassian.net/wiki/spaces/ED/pages/976617535/C1+SNICAR-AD+Shortwave+Radiation+for+Sea+Ice+and+Land

This PR also has the feature described here:
https://acme-climate.atlassian.net/wiki/spaces/ED/pages/990281763/C2+Snow-On-Seaice+Improvements

@rljacob
Copy link
Member

rljacob commented Jul 25, 2019

Why is this v2 feature turned off? If we want in v2, it should be on. Otherwise, @golaz has to remember to turn it on when tuning.

@jonbob
Copy link
Contributor Author

jonbob commented Jul 25, 2019

@rljacob - my understanding is that it's turned off until it goes through the post-v2 tuning stage. After that, a decision will be made about having it on by default and a separate PR would be made.

@jonbob
Copy link
Contributor Author

jonbob commented Jul 25, 2019

@rljacob - the snow grain model changes are minor bug fixes found by @njeffery during testing. We had made a single PR because they both had been pushed to the head of the seaice repo, but I can redo if necessary.

@rljacob
Copy link
Member

rljacob commented Jul 25, 2019

Thanks for clarifying the "snow grain model".

@rljacob
Copy link
Member

rljacob commented Jul 29, 2019

Turns out there are 2 features in this PR. They both have to have their code review documents approved.

@rljacob
Copy link
Member

rljacob commented Aug 7, 2019

Both code review documents for this PR have been approved.

jonbob added a commit that referenced this pull request Aug 12, 2019
@jonbob
Merge branch 'jonbob/seaice/update-snow-snicar' into next (PR #3058)
edbe4da 
Update mpas-seaice for snicar and snow grain model

This PR brings in a new mpas-source submodule that only updates the mpas-seaice
code, as well as the supporting scripts to match. The seaice has changes to:
* the snicar coding (MPAS-Dev/MPAS-Model PR #278);
* snow grain model (bug fixes)

Because these features are off by default, this PR is BFB but does have a
namelist change.

[NML]
[BFB]
@jonbob jonbob merged commit 9f34087 into master Aug 13, 2019
jonbob added a commit that referenced this pull request Aug 13, 2019
@jonbob
Merge branch 'jonbob/seaice/update-snow-snicar' (PR #3058)
23b872b 
Update mpas-seaice for snicar and snow grain model

This PR brings in a new mpas-source submodule that only updates the mpas-seaice
code, as well as the supporting scripts to match. The seaice has changes to:
* the snicar coding (MPAS-Dev/MPAS-Model PR #278);
* snow grain model (bug fixes)

Because these features are off by default, this PR is BFB but does have a
namelist change.

[NML]
[BFB]
@jonbob
Copy link
Contributor Author

jonbob commented Aug 13, 2019

merged to master and expected NML DIFFs blessed

@jonbob jonbob deleted the jonbob/seaice/update-snow-snicar branch August 13, 2019 14:42
rljacob pushed a commit that referenced this pull request Apr 21, 2021
@jedwards4b
Merge pull request #3058 from jedwards4b/use_installed_libraries
04d4138 
Use installed libraries
This change allows cesm to use installed PIO libraries should they exist on a system. An installed PIO library implies that the following items are defined in the environment:
PIO_VERSION_MAJOR, PIO_LIBDIR, PIO_INCDIR, PIO_TYPENAME_VALID_VALUES
I have installed pio modules on cheyenne for several combinations of compiler and mpilib.

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:

Code review:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akturner akturner akturner approved these changes

@chengdang chengdang chengdang approved these changes

Assignees

@jonbob jonbob

Labels
BFB PR leaves answers BFB mpas-seaice NML
Projects
None yet
Milestone
v2.0alpha
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonbob @rljacob @akturner @chengdang