Add new features for SNICAR-AD snow radiative transfer model #5102
Conversation
add _r8 fix bug fix bug fix bug fix bug Update SnowSnicarMod.F90 Update SnowSnicarMod.F90 Update controlMod.F90 Update SnowSnicarMod.F90 Update SnowSnicarMod.F90 Update SnowSnicarMod.F90 Update SnowSnicarMod.F90 Update SnowSnicarMod.F90 Update controlMod.F90 Update namelist_definition.xml Update SnowSnicarMod.F90 Update SnowSnicarMod.F90 Update SnowSnicarMod.F90 FIX Bug Update SnowSnicarMod.F90 Update controlMod.F90 Update SnowSnicarMod.F90 Update SnowSnicarMod.F90 Update SnowSnicarMod.F90 Update SnowSnicarMod.F90 Update elm_varctl.F90 Update SnowSnicarMod.F90 Update SnowSnicarMod.F90 Update controlMod.F90 clean the code
|
What does it mean to select "atmospheric conditions" when this is part of a global coupled run? |
|
Is this a feature need for v2 BGC runs? |
@bishtgautam What do you think? |
|
This feature isn't needed for BGC v2 sims. The model development was undertaken through one of the E3SM ecosystem projects. |
SNICAR-AD model calculates 5-band spectral albedo for snow, but the atmospheric model needs the surface albedo at just two bands (VIS and NIR) as I know. So the incoming surface spectral fluxes for 5 bands are needed to converse from 5-band to 2-band albedo. Here we provide the options for some typical different atmospheric conditions to describe the the incoming surface spectral fluxes for 5 bands. Current version just supports the same settings for the globe. In the future, we can improve both the land and atmospheric models to resolve this gap. |
|
We documented details of the development and evaluation of this new development in a manuscript, which is under review at GMD. The preprint of the manuscript can be found at: [https://gmd.copernicus.org/preprints/gmd-2022-67/]. |
|
@daleihao After renaming the test, you also need to move: |
Done. I have deleted the |
|
@peterdschwartz This PR looks ready to be merged. Can you please review this PR? |
| !!! Direct and diffuse flux under different atmospheric conditions | ||
| ! Direct-beam incident spectral flux: | ||
| call ncd_io( 'flx_wgt_dir', flx_wgt_dir, 'read', ncid, readvar=readvar, posNOTonfile=.true.) | ||
| if ((atm_type_index > 0) .and. (.not. readvar)) call endrun() |
There was a problem hiding this comment.
Should there be error messages for these endrun calls indicating which read failed?
|
Apologies, I forgot to hit the "submit review" button last week and just noticed that it wasn't showing up here. |
No worry. Thanks for your help. |
|
|
|
@peterdschwartz I have now uploaded the missing file on https://web.lcrc.anl.gov/public/e3sm/inputdata/lnd/clm2/snicardata/. |
…' into next(PR #5102) This development adds new features for the SNICAR-AD snow albedo model to consider the non-spherical snow grain shape, internal mixing of dust-snow and solar-zenith-angle dependence of surface spectral irradiance under different atmospheric profiles. These features are turned off by default in our development. When using SNICAR_AD model by use_snicar_ad = .true.: The snow grain shape can be selected by setting ‘snow_shape’ as: ‘sphere’, ‘spheroid’, ‘hexagonal_plate’, ‘koch_snowflake’. The internal mixing of dust-snow can be turned on by use_dust_snow_internal_mixing = .false.. The atmospheric conditions can be selected by setting ‘snicar_atm_type’ as: ‘default’, ‘mid-latitude_winter’, ‘mid-latitude_summer’, ‘sub-Arctic_winter’, ‘sub-Arctic_summer’, ‘summit_Greenland’, ‘high_mountain’. A test for this development is added. [BFB]
|
Merged to next |
|
@peterdschwartz when you copy-and-paste the PR description into the merge commit, remove all the markup. It creates unprintable characters in the log. |
|
Merged to master. The new test snowflake test was one of the ones that didn't complete on mappy so I'll have to submit that bless request later |
This development adds new features for the SNICAR-AD snow albedo model to consider the non-spherical snow grain shape,
internal mixing of dust-snow and solar-zenith-angle dependence of surface spectral irradiance under
different atmospheric profiles.
These features are turned off by default in our development. When using SNICAR_AD model by use_snicar_ad = .true.
The snow grain shape can be selected by setting snow_shape as:
‘sphere’, ‘spheroid’, ‘hexagonal_plate’, ‘koch_snowflake’.
The internal mixing of dust-snow can be turned on by use_dust_snow_internal_mixing = .true.
The atmospheric conditions can be selected by setting ‘snicar_atm_type’ as: ‘default’, ‘mid-latitude_winter’, ‘mid-latitude_summer’,
‘sub-Arctic_winter’, ‘sub-Arctic_summer’, ‘summit_Greenland’, ‘high_mountain’.
A test for this development is added.
[BFB]