-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjusted use_extrasnowlayers parameters based on Schneider et al., 2021 #6298
Merged
bishtgautam
merged 4 commits into
E3SM-Project:master
from
chloewhicker:cwhicker/elm/use_extrasnowlayers-tuning
Apr 12, 2024
Merged
adjusted use_extrasnowlayers parameters based on Schneider et al., 2021 #6298
bishtgautam
merged 4 commits into
E3SM-Project:master
from
chloewhicker:cwhicker/elm/use_extrasnowlayers-tuning
Apr 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishtgautam
requested changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good. I only have requests for a few minor stylistic code mods.
bishtgautam
approved these changes
Mar 25, 2024
bishtgautam
added a commit
that referenced
this pull request
Mar 25, 2024
…6298) Makes the following changes for `use_extrasnowlayers = .true.`: - Edits to tuning parameters to follow recommendations from Schneider et al., 2021, - Changes the snow refrozen grain radius (from 1000um to 1500um), and - Increase the max depth of snow (from 1m to 30m) [BFB]
chloewhicker
force-pushed
the
cwhicker/elm/use_extrasnowlayers-tuning
branch
from
April 11, 2024 23:40
1114575
to
0bbb3b9
Compare
bishtgautam
added a commit
that referenced
this pull request
Apr 11, 2024
…6298) Makes the following changes for `use_extrasnowlayers = .true.`: - Edits to tuning parameters to follow recommendations from Schneider et al., 2021, - Changes the snow refrozen grain radius (from 1000um to 1500um), and - Increase the max depth of snow (from 1m to 30m) - Adds three additional fields in ELM output by default. [BFB] except for tests longer than one month
This PR may have caused v3 restarts to no longer work with master. That needs to be fixed. |
Can you point me to the issue? |
Issue is #6365 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the following changes for
use_extrasnowlayers = .true.
:[BFB] except for tests longer than one month