Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusted use_extrasnowlayers parameters based on Schneider et al., 2021 #6298

Conversation

chloewhicker
Copy link
Contributor

@chloewhicker chloewhicker commented Mar 18, 2024

Makes the following changes for use_extrasnowlayers = .true.:

  • Edits to tuning parameters to follow recommendations from Schneider et al., 2021,
  • Changes the snow refrozen grain radius (from 1000um to 1500um), and
  • Increase the max depth of snow (from 1m to 30m)
  • Adds three additional fields in ELM output by default.

[BFB] except for tests longer than one month

@rljacob rljacob assigned jonbob and bishtgautam and unassigned jonbob Mar 18, 2024
@rljacob rljacob added the Land label Mar 19, 2024
Copy link
Contributor

@bishtgautam bishtgautam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. I only have requests for a few minor stylistic code mods.

components/elm/src/data_types/ColumnDataType.F90 Outdated Show resolved Hide resolved
components/elm/src/data_types/ColumnDataType.F90 Outdated Show resolved Hide resolved
components/elm/src/main/elm_instMod.F90 Outdated Show resolved Hide resolved
@bishtgautam bishtgautam self-requested a review March 25, 2024 18:46
bishtgautam added a commit that referenced this pull request Mar 25, 2024
…6298)

Makes the following changes for `use_extrasnowlayers = .true.`:
- Edits to tuning parameters to follow recommendations from Schneider et al., 2021,
- Changes the snow refrozen grain radius (from 1000um to 1500um), and
- Increase the max depth of snow (from 1m to 30m)

[BFB]
bishtgautam pushed a commit that referenced this pull request Mar 26, 2024
…ext (PR #6298)"

This reverts commit be4dfde, reversing
changes made to 731ef33.
@chloewhicker chloewhicker force-pushed the cwhicker/elm/use_extrasnowlayers-tuning branch from 1114575 to 0bbb3b9 Compare April 11, 2024 23:40
bishtgautam added a commit that referenced this pull request Apr 11, 2024
…6298)

Makes the following changes for `use_extrasnowlayers = .true.`:
- Edits to tuning parameters to follow recommendations from Schneider et al., 2021,
- Changes the snow refrozen grain radius (from 1000um to 1500um), and
- Increase the max depth of snow (from 1m to 30m)
- Adds three additional fields in ELM output by default.

[BFB] except for tests longer than one month
@bishtgautam bishtgautam merged commit 75a1d26 into E3SM-Project:master Apr 12, 2024
2 checks passed
@rljacob
Copy link
Member

rljacob commented Apr 22, 2024

This PR may have caused v3 restarts to no longer work with master. That needs to be fixed.

@chloewhicker
Copy link
Contributor Author

Can you point me to the issue?

@rljacob
Copy link
Member

rljacob commented Apr 24, 2024

Issue is #6365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants