-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update v3 SSP compsets/configurations/tests and use_case files #6335
Conversation
|
Hi @wlin7 , regarding your E90 checklist and notes below, I assume the file created in 2017 refers to this file For E3SMv3, we should use this E90 file for ALL SSP scenarios because E90 is an artificial tracer which doesn't change with SSPs.
|
Hi @hwangacme @mingxuanwupnnl @tangq @keziming @jinboxie , @keziming @bishtgautam You may start with the checklist and notes in the PR message. Available historical and SSP tests may be helpful for comparing the settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me except the prescribed methane settings pointing to the 1990s climatology. These settings are likely not used and should be deleted to avoid confusions.
<!-- prescribed methane --> | ||
<prescribed_ghg_file >ch4_oxid_1.9x2.5_L26_1990-1999clim.c090804.nc</prescribed_ghg_file> | ||
<prescribed_ghg_datapath >atm/cam/chem/methane</prescribed_ghg_datapath> | ||
<prescribed_ghg_type >CYCLICAL</prescribed_ghg_type> | ||
<prescribed_ghg_cycle_yr >1995</prescribed_ghg_cycle_yr> | ||
<prescribed_ghg_filelist >''</prescribed_ghg_filelist> | ||
<prescribed_ghg_specifier>'prsd_ch4:CH4'</prescribed_ghg_specifier> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why we need this prescribed methane file, which appears to be the seasonal cycle climatology of 1990-1999, for the SSPs. I confirmed that "prsd_ch4" is not defined in chem_mech.in, so it is highly likely these settings are not used in the simulation. Shall we delete it here and in other two SSP use case files too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- prescribed methane --> | ||
<prescribed_ghg_file >ch4_oxid_1.9x2.5_L26_1990-1999clim.c090804.nc</prescribed_ghg_file> | ||
<prescribed_ghg_datapath >atm/cam/chem/methane</prescribed_ghg_datapath> | ||
<prescribed_ghg_type >CYCLICAL</prescribed_ghg_type> | ||
<prescribed_ghg_cycle_yr >1995</prescribed_ghg_cycle_yr> | ||
<prescribed_ghg_filelist >''</prescribed_ghg_filelist> | ||
<prescribed_ghg_specifier>'prsd_ch4:CH4'</prescribed_ghg_specifier> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments above.
<!-- prescribed methane --> | ||
<prescribed_ghg_file >ch4_oxid_1.9x2.5_L26_1990-1999clim.c090804.nc</prescribed_ghg_file> | ||
<prescribed_ghg_datapath >atm/cam/chem/methane</prescribed_ghg_datapath> | ||
<prescribed_ghg_type >CYCLICAL</prescribed_ghg_type> | ||
<prescribed_ghg_cycle_yr >1995</prescribed_ghg_cycle_yr> | ||
<prescribed_ghg_filelist >''</prescribed_ghg_filelist> | ||
<prescribed_ghg_specifier>'prsd_ch4:CH4'</prescribed_ghg_specifier> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @wlin7 Emission files and oxidant files look good to me.
<!-- *** NOT USED FOR SATELLITE PHENOLOGY *** | ||
<stream_year_first_ndep phys="elm" use_cn=".true." >1850</stream_year_first_ndep> | ||
<stream_year_last_ndep phys="elm" use_cn=".true." >2005</stream_year_last_ndep> | ||
<model_year_align_ndep phys="elm" use_cn=".true." >1850</model_year_align_ndep> | ||
|
||
<stream_year_first_pdep phys="elm" use_cn=".true." >2000</stream_year_first_pdep> | ||
<stream_year_last_pdep phys="elm" use_cn=".true." >2000</stream_year_last_pdep> | ||
<model_year_align_pdep phys="elm" use_cn=".true." >2000</model_year_align_pdep> | ||
|
||
<stream_year_first_popdens phys="elm" use_cn=".true." >1850</stream_year_first_popdens> | ||
<stream_year_last_popdens phys="elm" use_cn=".true." >2010</stream_year_last_popdens> | ||
<model_year_align_popdens phys="elm" use_cn=".true." >1850</model_year_align_popdens> | ||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These might need to be uncommented, and @acme-y9s might know more about these BGC settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for careful review, @bishtgautam . I didn't realize the whole block was commented out.
The settings, if uncommented, would be the same as for historical (CMIP6_transient). Are they suitable for SSPs?
Currently, with the blocked commented out, stream_year values for *_pdep, *_ndep, and *_popdens
are all using 2000.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going with the transient settings as for the historical use_case for now.
Hi @tangq , the settings for the prescribed methane section has been all removed from the SSP use_case files via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problems found. Just identified some minor naming issues.
@@ -113,12 +113,17 @@ | |||
|
|||
<compset> | |||
<alias>WCYCLSSP585</alias> | |||
<lname>SSP585SOI_EAM%CMIP6_ELM%SPBC_MPASSI_MPASO_MOSART_SGLC_SWAV</lname> | |||
<lname>SSP585SOI_EAM%CMIP6_ELM%CNPRDCTCBCTOP_MPASSI_MPASO_MOSART_SGLC_SWAV</lname> | |||
</compset> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any particular consideration to name these SSPs under WCYCL? These compsets are now being created for different groups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hwangacme , that is more of continuing the naming convention we have been having. We will have still a distinction of WCYCLSSP, CRYOSSP, BGCSSP. The WCYCL ones come first.
<so2_ext_file >atm/cam/chem/trop_mozart_aero/emis/CMIP6_SSP245_ne30/cmip6_ssp245_mam4_so2_volc_elev_2015-2100_c240331.nc </so2_ext_file> | ||
<soag0_ext_file >atm/cam/chem/trop_mozart_aero/emis/CMIP6_SSP245_ne30/emissions-cmip6_ssp245_e3sm_SOAG0_elev_2015-2100_1.9x2.5_c20240219.nc </soag0_ext_file> | ||
<bc_a4_ext_file >atm/cam/chem/trop_mozart_aero/emis/CMIP6_SSP245_ne30/cmip6_ssp245_mam4_bc_a4_elev_2015-2100_c200716.nc </bc_a4_ext_file> | ||
<mam7_num_a1_ext_file >atm/cam/chem/trop_mozart_aero/emis/CMIP6_SSP245_ne30/cmip6_ssp245_mam4_num_a1_elev_2015-2100_c200716.nc </mam7_num_a1_ext_file> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we change these "mam7" pointers of input files to "mam4"? They look quite confusing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed appear confusing. Does 'a1' refer to the same thing in mam7 and mam4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
num_a1 does refer to the same thing for both MAM4 and MAM7, but num_a3 for MAM7 below refers to num_a4 for MAM4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @hwangacme . Indeed in all the use_case files, there is a comment that mam7_num_a3 is to set num_a4 emission. If to change the pointers, need to update all use_case files and namelist_default, as well as build-namelist. These should be fine; but would also introduce NML diff for all standard tests (and make nml in ongoing production simulations look different). We can apply the changes at a later time.
@wlin7 is this ready for merging? |
@rljacob , the land settings need further review/input. @acme-y9s and @thorntonpe , can you please take a look? It is about the use_case settings to work with the BGC land. |
@wlin7 @bishtgautam For the nitrogen deposition (nden) and population density (popdens) files, we do have the transient files that we used for BGCv1 simulation (like SSP585). For the phosphorus deposition file (pden) we only one year. If you do not specify the those files in your use_case file, the model will have default setting files (maybe based on you simulation year ), but the default files may not what you need. There should be ndep and popdens files for each SSPs, you can specify thoses files in each SSP's use_case file. I did specify those files for our BGCv1 SSP585 case, you can have a look if you want. Or, if you need help, feel free to let me know. |
hist_fincl2 = 'H2OSNO', 'FSNO', 'QRUNOFF', 'QSNOMELT', 'FSNO_EFF', 'SNORDSL', 'SNOW', 'FSDS', 'FSR', 'FLDS', 'FIRE', 'FIRA' | ||
hist_mfilt = 1,365 | ||
hist_nhtfrq = -24,-24 | ||
hist_nhtfrq = 0,-24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be -24 for testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching it. Done, for user_nl_eam as well.
Thanks, @acme-y9s definitely need more help from you on this. Can you please provide the files (the path if ready on our machine) and the proper year-align settings? We can update the specification in a next PR. |
Update v3 SSP compsets/configurations/tests and use_case files Add/update SSP compsets with standard v3 configurations. The changes include: . SSP245, SSP370, SSP585 . atm and land configurations . atm and land use_case files . wcprodssp testmod (replacing workaround that are based on hybrid v2/v3 configurations) [non-BFB] only for SSP tests [NML] changes only for SSP tests * origin/wlin/update_v3ssp_compsets: Change h0 tapes output frequency for the SSP testmod Set SSP245 default STARTDATE Update SSP use_case files with transient BGC land mode settings Update the SSP testmod Remove prescribed methane section from use_case files for SSPs Update v3 SSP585 use_case files Add v3 SSP245 compsets and use_case files Update SSP370 prescribed oxidant file Rename v3 SSP370 LULC file Replace old E90 file with one for all v3 SSP scenarios Update SSP370 compset/configuration and use_case files
Merged to next. |
Update v3 SSP compsets/configurations/tests and use_case files Add/update SSP compsets with standard v3 configurations. The changes include: . SSP245, SSP370, SSP585 . atm and land configurations . atm and land use_case files . wcprodssp testmod (replacing workaround that are based on hybrid v2/v3 configurations) [non-BFB] only for SSP tests [NML] changes only for SSP tests
Remerged to next after restoring the config settings for 4xCO2 and 1pctCO2 compset. Pattern |
Only expected SSP test diffs with this PR on next (and compy's SSP370 FAIL due to permission to download additional forcing files). The PR is merged to master (to create a master repo with SSP compsets). Requests for bless SSP test DIFFs are submitted but before they are blessed, both next and master will see diff on Monday. |
@wlin7 Maybe due to machine issues at the time, but this PR may still have DIFFs on pm-cpu that need to be blessed(for example https://my.cdash.org/viewTest.php?onlyfailed&buildid=2561805). |
Add/update SSP compsets with standard v3 configurations. The changes include:
[non-BFB] only for SSP tests
[NML] changes only for SSP tests
Checklist and Notes
Available test runs for comparing nml files (atm_in and lnd_in) if they are helpful for your review