Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add four new joint histograms to the MODIS simulator #6407

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Add four new joint histograms to the MODIS simulator #6407

merged 4 commits into from
Jul 3, 2024
+1,882 −38

Conversation

zyuying
Copy link
Contributor

@zyuying zyuying commented May 9, 2024 •
edited by singhbalwinder
Loading

Four new joint histogram diagnostics are computed and added to the MODIS simulator (shown in attached slide2). The diagnostics include :
1&2) “CLLIQMODIS” and “CLDICEMODIS” : cloud-fraction joint histograms partitioned by cloud-top pressure (CTP) vs. cloud optical thickness (COT) for liquid-topped clouds and ice-topped clouds, respectively
3) “LWPRLMODIS” : LWP vs. cloud particle size (CER) histogram for liquid-topped clouds
4) “IWPRIMODIS” : IWP vs. CER histogram for ice-topped clouds

The joint histograms match the MODIS observational dataset described by Pincus et al. 2023.

Also, the CER edges of the histogram bins have been changed slightly from their original versions. Three changes are :
(1) The lower bound of the smallest CER bin for liquid-topped clouds has been changed from 0 microns to 4 microns
(2) One of the CER bin edges has been changed from 13 microns to 12.5 microns
(3) The lower bound of the smallest CER bin for ice-topped clouds has been changed from 0 microns to 5 microns

This causes minor changes in the MODIS joint histograms (“CLRLMODIS” and “CLRIMODIS”) with CER as a dimension (shown in attached slide1).
No other variables are affected by the code modifications.

File changes:
cosp2/Cosp.cmake
cosp2/local/cosp.F90
cam/cospsimulator_intr.F90
Add cosp_config.F90 and modis_simulator.F90 into cosp2/local
MODISdiag_jointhist.pdf

[NBFB]

@zyuying zyuying requested review from wlin7 and brhillman May 9, 2024 23:48
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6407/
on branch gh-pages at 2024-06-05 20:55 UTC

@rljacob rljacob assigned singhbalwinder and wlin7 and unassigned wlin7 May 13, 2024
@rljacob
Copy link
Member

rljacob commented May 30, 2024

@wlin7 please review.

wlin7
wlin7 reviewed May 30, 2024
View reviewed changes
components/eam/src/physics/cam/cospsimulator_intr.F90
flag_xyfill=.true., fill_value=R_UNDEF)
! float lwprlmodis ( time, reffliq, lwp, loc )
call addfld ('LWPRLMODIS',(/'cosp_lwp_modis','cosp_reffliq '/),'A','%','MODIS Cloud Area Fraction', &
flag_xyfill=.true., fill_value=R_UNDEF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zyuying The longnames for all the above fields are called "MODIS Cloud Area Fraction". Useful to make them distinguishable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wlin7 I have changed the longnames for all the joint-histogram variables. Thanks.

@zyuying
Update cospsimulator_intr.F90
bacb504 
Change the longnames for all the joint-histogram variables to make them distinguishable.
@rljacob
Copy link
Member

rljacob commented Jun 13, 2024

@wlin7 will test again.

wlin7
wlin7 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@wlin7 wlin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good; tests confirmed BFB except for new variables, and two existing variables (CLRLMODIS and CLRIMODIS) due to changes in bin boundaries, which are noted in the PR message.

@wlin7
Copy link
Contributor

wlin7 commented Jun 13, 2024

@rljacob , this PR add new variables, also cause two existing diagnostics variables to differ. But the affected two variables (CLRLMODIS and CLRIMODIS) are not among the requested output for v3.LR simulation campaign. Sounds safe to have this on master (though standard tests not exactly reproducing eam.h0). We may also add it to v3.0.1 milestone, as it enhances the COSP diagnostics suite.

@rljacob rljacob added this to the v3.0.1 milestone Jun 27, 2024
@rljacob
Copy link
Member

rljacob commented Jun 27, 2024

@singhbalwinder can you merge this to next today?

@singhbalwinder singhbalwinder added the non-BFB PR makes roundoff changes to answers. label Jun 28, 2024
singhbalwinder added a commit that referenced this pull request Jun 28, 2024
@singhbalwinder
Merge branch 'YuyingZhang/atm/4histMODIS' into next (PR #6407)
5f1c125 
Add four new joint histograms to the MODIS simulator

Four new joint histogram diagnostics are computed and added to the
MODIS simulator (shown in attached slide2). The diagnostics include :
1&2) “CLLIQMODIS” and “CLDICEMODIS” : cloud-fraction joint histograms
partitioned by cloud-top pressure (CTP) vs. cloud optical thickness
(COT) for liquid-topped clouds and ice-topped clouds, respectively
3) “LWPRLMODIS” : LWP vs. cloud particle size (CER) histogram for
liquid-topped clouds
4) “IWPRIMODIS” : IWP vs. CER histogram for ice-topped clouds

The joint histograms match the MODIS observational dataset described
by Pincus et al. 2023.

Also, the CER edges of the histogram bins have been changed slightly
from their original versions. Three changes are :
(1) The lower bound of the smallest CER bin for liquid-topped clouds
has been changed from 0 microns to 4 microns
(2) One of the CER bin edges has been changed from 13 microns to 12.5
microns
(3) The lower bound of the smallest CER bin for ice-topped clouds has
been changed from 0 microns to 5 microns

This causes minor changes in the MODIS joint histograms (“CLRLMODIS”
and “CLRIMODIS”) with CER as a dimension (shown in attached slide1).
No other variables are affected by the code modifications.

File changes:
cosp2/Cosp.cmake
cosp2/local/cosp.F90
cam/cospsimulator_intr.F90
Add cosp_config.F90 and modis_simulator.F90 into cosp2/local
MODISdiag_jointhist.pdf

[NBFB]

* YuyingZhang/atm/4histMODIS:
  Update cospsimulator_intr.F90
  Add files via upload
  Add files via upload
  Add files via upload
@singhbalwinder
Copy link
Contributor

Merged with next.

I also labeled it NBFB as @wlin7 mentioned above that it may cause NBFB for two diagnostic variables.

@rljacob
Copy link
Member

rljacob commented Jun 28, 2024

To any of our tests output those variables?

@singhbalwinder
Copy link
Contributor

I am not sure. We have some COSP tests, so it might cause NBFB answers for those tests.

@singhbalwinder
Copy link
Contributor

I see the following COSP test failing on next Chrysalis:

ERS_Ln9.ne4pg2_ne4pg2.FRCE-MMF1.chrysalis_intel.eam-cosp_nhtfrq9
SMS_D_Ln5.ne4pg2_oQU480.F2010.chrysalis_intel.eam-cosplite_nhtfrq5

The RMS diffs are in the following variables for the ERS COSP test:

cosp_reffice       
cosp_reffice_bnds  
cosp_reffliq       
cosp_reffliq_bnds  
CLRIMODIS

The RMS diffs are in the following variables for the SMS COSP-lite test:

cosp_reffice           
cosp_reffice_bnds
cosp_reffliq           
cosp_reffliq_bnds 
CLRIMODIS           
CLRLMODIS

Does that look right? Should I go ahead and merge it and ask to bless these tests?

@rljacob
Copy link
Member

rljacob commented Jun 30, 2024

@zyuying please see above

@wlin7
Copy link
Contributor

wlin7 commented Jul 3, 2024

Yes, @singhbalwinder . Those diffs are expected as described in the PR message and the comment above. The bin center and bounds for cosp_ref### and _bnd are updated, causing existing variables CLRIMODIS and CLRLMODIS to also differ.

Other tests (e.g., prodt tests) that report diffs in eam.h# files are due to the changes in these four coordinate variables:
cosp_reffice , cosp_reffice_bnds, cosp_reffliq, cosp_reffliq_bnds, even when the actual COSP cloud fields are not output.

@zyuying
Copy link
Contributor Author

zyuying commented Jul 3, 2024 •
edited
Loading

@singhbalwinder, the diffs are expected as mentioned in the description of this PR. @wlin7, thanks for your explanation.
Please go ahead to merge it. Thanks.

@singhbalwinder singhbalwinder merged commit 5ac436a into master Jul 3, 2024
21 checks passed
@singhbalwinder singhbalwinder deleted the YuyingZhang/atm/4histMODIS branch July 3, 2024 16:46
@singhbalwinder
Copy link
Contributor

Thank you both for verifying. Merged to master.

@singhbalwinder
Copy link
Contributor

Issued bless requests for Chrysalis and pm-cpu next branch for the following tests:

ERS_Ln9.ne4pg2_ne4pg2.FRCE-MMF1.<machine>_<compiler>.eam-cosp_nhtfrq9
SMS_D_Ln5.ne4pg2_oQU480.F2010.<machine>_<compiler>.eam-cosplite_nhtfrq5

@rljacob
Copy link
Member

rljacob commented Jul 3, 2024

Anything with "wcprod" testmod will have COSP output in it and needs to be blessed. Thats the entire prod suit and a few more cases in integration.

@singhbalwinder
Copy link
Contributor

I have asked for the following blesses as well:

Chrysalis integration:
SMS_D_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel.allactive-wcprod
SMS_D_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCLSSP370.chrysalis_intel.allactive-wcprodssp

Anvil prod:
SMS_Ld1.ne30pg2_EC30to60E2r2.WCYCL1850-4xCO2.anvil_intel.allactive-wcprod
SMS_Ld1.ne30pg2_EC30to60E2r2.WCYCLSSP585.anvil_intel.allactive-wcprodssp

PM-CPU Prod:
SMS_Ld1.ne30pg2_r05_IcoswISC30E3r5.F20TR.pm-cpu_intel.eam-wcprod_F20TR
SMS_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850-1pctCO2.pm-cpu_intel.allactive-wcprod_1850_1pctCO2
SMS_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850-4xCO2.pm-cpu_intel.allactive-wcprod_1850_4xCO2
SMS_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.pm-cpu_intel.allactive-wcprod_1850
SMS_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCLSSP370.pm-cpu_intel.allactive-wcprodssp
SMS_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCLSSP585.pm-cpu_intel.allactive-wcprodssp
SMS_Ld1_PS.northamericax4v1pg2_WC14to60E2r3.WCYCL1850.pm-cpu_intel.allactive-wcprodrrm_1850
SMS_Ln5.ne30pg2_r05_IcoswISC30E3r5.F2010.pm-cpu_intel.eam-wcprod_F2010

Chrysalis prod:
SMS_Ld1.ne30pg2_r05_IcoswISC30E3r5.F20TR.chrysalis_intel.eam-wcprod_F20TR
SMS_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850-1pctCO2.chrysalis_intel.allactive-wcprod_1850_1pctCO2
SMS_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850-4xCO2.chrysalis_intel.allactive-wcprod_1850_4xCO2
SMS_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel.allactive-wcprod_1850
SMS_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCLSSP370.chrysalis_intel.allactive-wcprodssp
SMS_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCLSSP585.chrysalis_intel.allactive-wcprodssp
SMS_Ld1_PS.northamericax4v1pg2_WC14to60E2r3.WCYCL1850.chrysalis_intel.allactive-wcprodrrm_1850
SMS_Ln5.ne30pg2_r05_IcoswISC30E3r5.F2010.chrysalis_intel.eam-wcprod_F2010

PM-CPU integration:
SMS_D_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.pm-cpu_intel.allactive-wcprod
SMS_D_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCLSSP370.pm-cpu_intel.allactive-wcprodssp

@mahf708 mahf708 mentioned this pull request Jul 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlin7 wlin7 wlin7 approved these changes

@brhillman brhillman Awaiting requested review from brhillman

Assignees

@singhbalwinder singhbalwinder

Labels
Atmosphere non-BFB PR makes roundoff changes to answers.
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zyuying @rljacob @wlin7 @singhbalwinder