Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the ELM's SPBC compset #6438

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

bishtgautam
Copy link
Contributor

Removes turning on of the subgrid solar topographic radiation scheme.

[BFB]

Removes turning on of the subgrid solar topographic radiation scheme.

[BFB]
Copy link
Collaborator

@daleihao daleihao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add SPBCTOP as below
<value compset="_EAM%CMIP6_ELM%[^_]*SPBCTOP" >-bgc sp -solar_rad_scheme top</value>

Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6438/
on branch gh-pages at 2024-05-22 04:02 UTC

@rljacob rljacob added this to the v3.0.1 milestone Jun 27, 2024
@rljacob
Copy link
Member

rljacob commented Jun 27, 2024

@daleihao please review

@rljacob
Copy link
Member

rljacob commented Jul 3, 2024

@peterdschwartz you can start merging this.

@rljacob
Copy link
Member

rljacob commented Jul 3, 2024

@bishtgautam did you see @daleihao 's question above?

@bishtgautam
Copy link
Contributor Author

I missed @daleihao's comment earlier.

Let's not add the _EAM%CMIP6_ELM%[^_]*SPBCTOP because it would be an active EAM that we aren't currently using in the v3 WC campaign.

peterdschwartz added a commit that referenced this pull request Jul 8, 2024
Removes turning on of the subgrid solar topographic radiation scheme.

[BFB]
@peterdschwartz
Copy link
Contributor

merged to next

@peterdschwartz peterdschwartz merged commit 12f7249 into master Jul 9, 2024
21 checks passed
@peterdschwartz peterdschwartz deleted the bishtgautam/lnd/fix-spbc-compset branch July 9, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB Land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants