-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package versions for v. 1.2.3 #26
Conversation
@sterlingbaldwin, I'm working on a new version of e3sm-unified. It seems like processflow depends on acme_diags, which depends on cdp=1.1.0. I think processflow should, indstead, depend on e3sm_diags, which should depend on the same version of cdp that I have above. Could you make that fix and perhaps update the minor version of processflow accordingly? @zshaheen, let me know if what I say above isn't correct. |
@zshaheen, is this the desired version of e3sm_diags? @jhkennedy, is there an update for livvkit? @czender, nco==4.7.7, correct? @doutriaux1, any updates to CDAT other than cdp==1.4.0 (which is required for compatibility with e3sm_diags)? |
@xylar I talked to Zeshawn about this a bit ago actually. The latest code on processflow master has e3sm_diags instead of acme_diags, but I havent built a new version yet for conda. I'll take care of that and publish a new minor version update. |
@xylar Yes, version For E3SM, the only reason cdp is in there is due to e3sm_diags. When I release a new version of e3sm_diags, I report the changes on this Confluence page. So when a cdp is upgraded for e3sm_diags, should I still update it there? I think just having whatever version of e3sm_diags we need would be fine, since it'll automatically get the appropriate version of cdp. |
Yes, NCO 4.7.7 is correct |
@doutriaux1, cdm2==3.0.1 was already set in 1.2.2: https://github.com/E3SM-Project/e3sm-unified/pull/26/files#diff-08ec1c8c69bdd6ee90a1634993202eedR12 |
@zshaheen wrote:
Okay, so I should just take cdp out as a dependency and let e3sm_diags decide, right? |
@xylar, Yes, we should be fine with removing cdp as a dependency in the e3sm unified env. |
f606538
to
acdbe02
Compare
@xylar 2.1.6 is still the right version for LIVVkit -- 2.2.0 is still a little ways off. |
@sterlingbaldwin, I just tried the latest upload (processflow 2.1.0) but the hdf5 version is not compatible with conda-forge (e.g. NCO 2.7.7). Could you rebuild with hdf5 1.10.3? Perhaps 2.1.0 wasn't ready to test in any case, but I figured I'd give it a try. |
I dont tag specific version of anything besides Globus, which I dont think should affect the hdf5 version. Even though I dont use it directly, I'll try rebuilding with hdf5 == 1.10.3 and see if there are any conflicts. |
@sterlingbaldwin, hmm, I'm still seeing conflicts but this time nothing to do with hdf5. I just see:
Maybe this is a different build of processflow 2.1.0? You said you don't specify a version of nco? |
My requirements read as follows:
I havent done a rebuild yet, so if anything changed it wasnt because of me. Conda can be weird sometimes, for example I had to add a couple things like jmespath that I dont need, and are listed as dependencies of globus, but once or twice I had an install just not bring them in. |
Yeah, frustrating! I'm going to try to build processflow myself and upload to my own channel to see if I can get it working. I'll keep you posted. |
@sterlingbaldwin, Okay, after a bunch of mucking around, I think the problem is that nco=4.7.7 was built with hdf5=1.10.3 but ncl=6.5.0 was build with hdf5=1.10.2. I'm not sure we can proceed until ncl has been updated. I got the impression from @ocefpaf that we shouldn't expect packages to get rebuilt with the latest pinnings too immediately because conda-forge developers are focused on compilers at the moment. |
That would make a lot of sense. NCL has always been a little slow to rebuild. Ideally I would like to drop support for AMWG and just support e3sm_diags which doesnt have any of these problems, but for the short term Im not sure what the solution would be. What I did in the past was just require that users install ncl for themselves which is a bit of a pain without using the conda version. Do you have any suggestions? I could just go back to requiring users that want to use AMWG to handle their own dependencies for it. |
Hmm, I think it might be worth waiting to see if NCL gets updated on conda-forge. I'm not aware of a pressing need to have the latest version of any of the packages that would be updated here (@czender or @zshaheen, please correct me if I'm wrong). It would be better to wait for a clean solution than to rush a difficult one. |
I don't personally use NCL, but I know there are other people that do, outside of the AMWG package. |
Yes, I'm also aware of some NCL users so best to make sure it's available, I think... |
It probably doesn't need to be updated often, unless there are specific dependencies. |
@xylar @sterlingbaldwin, for us, there's no urgent need to have the latest e3sm_diags available via the unified env. |
@milenaveneziani, NCL depends on an hdf5 and that's the conflict we're having with NCO (hdf5 1.10.2 vs. 1.10.3). If not for that conflict, I would agree there's no urgent need to update. |
I am unaware of any urgent reason to upgrade the HDF, GSL, or ESMF libraries upon which NCO depends. They could also be downgraded without noticeable harm. The key library to ensure is netCDF >= 4.6.1. Nothing else is as crucial. |
@czender, I guess you're right that we could do a build with NCO 4.7.7 but hdf5 1.10.2 and that might solve the problem for now. Let me see what I hear back from the NCL folks and we'll do that if need be. |
acdbe02
to
00d0f80
Compare
Closes #25 |
Updated versions:
Added: