New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENSO updates #295
ENSO updates #295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chengzhuzhang I still need to run/test this code, but are these changes what you had in mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, the system tests need to be updated for parameters specifying year range.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chengzhuzhang Ready for review. I tagged you on a few questions I had.
I meant to add an entry with this netflux4 function needs to take in account the qflx to lflx conversion. Or we can have a new netflux4 function just for take care of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chengzhuzhang See the second commit for my changes. Please test again and see if that works for you. If so, I'll fixup
the commits and merge.
I spent some time trying to add a test case, but that ran into complications. I wanted to add a test where the start years are unequal. However, it looks like we only have two years of data for TREFHT
in the tests directory, and if you set one of the start years to equal the end year, then the code fails (this is true on master
as well). I'm not sure if that's expected behavior or not -- in any case, that would be outside the scope of this pull request to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://compy-dtn.pnl.gov/zhan429/enso_reg_diags_alpha22_to_obs/viewer/enso_diags/index.html
The regression map has succesfully generated, but scatter plots are missing. due to the AttributeError: 'EnsoDiagsParameter' object has no attribute 'start_yr'
error..
Resolves #292.
NET_FLUX_SRF
andLHFLX
.TS
ifSST
is not available.start_yr
andend_yr
parameter handling.