Upgrading ADIOS file format to BP5 for SCORPIO #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dqwu
added
enhancement
Perf
Next Release
|
For some SCORPIO unit tests to pass with BP5 format, a patch |
|
Also, there are some confirmed memory leaks with latest ADIOS2 2.8.3 |
dqwu
force-pushed
the
dqwu/adios2_bp5_integration
branch
2 times, most recently
from
28fdcdd
to
188fffc
Compare
tkurc
approved these changes
Oct 27, 2022
This patch is provided by Tahsin Kurc, which upgrades ADIOS file format from BP4 to BP5. Additionally, there are some code changes to use a subset of tasks as ADIOS I/O nodes along with buffer merging to improve the write performance of ADIOS type. MPI_COMM_NULL (instead of NULL) is now utilized to initialize or free those MPI comms used by ADIOS type.
dqwu
force-pushed
the
dqwu/adios2_bp5_integration
branch
from
188fffc
to
3e33115
Compare
jayeshkrishna
approved these changes
Oct 28, 2022
dqwu
force-pushed
the
dqwu/adios2_bp5_integration
branch
from
f7facb9
to
832fce3
Compare
PIO_MAX_ADIOS_DECOMPS: maximum number of decompositions registered with ADIOS type (default value is 64K) PIO_MAX_CACHED_STEPS_FOR_ADIOS: maximum number of cached application steps for ADIOS type (default value is 128) Until ADIOS end step is called, data will be cached in memory. It may be necessary to reduce PIO_MAX_CACHED_STEPS_FOR_ADIOS for large runs on machines with relatively small amount of memory.
dqwu
force-pushed
the
dqwu/adios2_bp5_integration
branch
from
832fce3
to
9cf4aba
Compare
dqwu
added a commit
that referenced
this pull request
Oct 29, 2022
This patch is provided by @tkurc (Tahsin Kurc), which upgrades ADIOS file format from BP4 to BP5. Additionally, there are some code changes to use a subset of tasks as ADIOS I/O nodes along with buffer merging to improve the write performance of ADIOS type. * dqwu/adios2_bp5_integration: Making some parameters used by ADIOS type configurable Miscellaneous enhancements and bug fixes for ADIOS type in SCORPIO
tkurc
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is provided by @tkurc (Tahsin Kurc), which upgrades
ADIOS file format from BP4 to BP5.
Additionally, there are some code changes to use a subset of tasks
as ADIOS I/O nodes along with buffer merging to improve the write
performance of ADIOS type.