-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SerializeStub() method to Chart class. Added more error checks [GH-626] #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nseam
commented
Jan 12, 2022
•
edited by kenorb
Loading
edited by kenorb
- Fixes Invalid pointer access in 'SerializerCsv.mqh' (277,45) #626.
…) returning an error even if iCustom was not yet executed.
kenorb
added a commit
that referenced
this pull request
Jan 28, 2022
* origin/master: Added SerializeStub() method to Chart class. Added more error checks. (#629) Improves tasks return logic EA: Adds enum's comment Adds Indi_Custom indicator Indi_MA: Renames InpMAMethod to _ma_method to avoid global variable conflicts Indi_MA: Renames InpMAPeriod to _ma_period to avoid global variable conflicts Initial new Account classes Account: Moves enums, defines and structs to Account/ Fixed Dicts to take into consideration overflow listeners. GHA: Removes init-platform due to hang GHA: Uses 4.0.0.1349 to compile main tests GHA: Uses 4.0.0.1349 to run main tests Fixes problem with non-visual mode 4086 errors due to BarsCalculated() returning an error even if iCustom was not yet executed. Indicator: Moves Init() to protected section Indi_AC: Sets 2 modes when using iCustom() Chart: ChartTf: Adds SecsToTf() GHA: Adds Tick tests Fixed Dicts to take into consideration overflow listeners. Tick/TickManager: Adds TickManagerOverflowListener() Adds TickManager
kenorb
added a commit
that referenced
this pull request
Mar 24, 2022
* tag 'v2.010': Corrects broken links Moves Deal enums to Deal.enum.h Indicators: Moves resetting handle on change to Indicator class Indicator: Adds state property setter Fixes possible loss of data due to type conversion in the latest MTE build Adds Markdown table for MQL/CPP syntax Adds CONTRIBUTING.md file Adds Twitter badge Improves comments for docblock [GH-638] EA: Improves risk management of order price stops [GH-42] IndicatorsTest: Fixes Indi_Drawer Added SerializeStub() method to Chart class. Added more error checks. (#629)
kenorb
added a commit
that referenced
this pull request
Jul 2, 2022
* tag 'v2.011': Indicators: Adds Indicator source type and mode to constructor's argument. Moves indicator data related methods to IndicatorData Indicator: Moves GetValuePrice() to IndicatorData Splits IndicatorParams struct into IndicatorDataParams Refactors IndicatorData class to be inherited by Indicator class Refs #337 New week detection. Added check if it's the first day of the week (which is Monday in MQL). Previously we only checked if current day of the week has changed. CPP: Removes EnumToString Corrects broken links Moves Deal enums to Deal.enum.h Indicators: Moves resetting handle on change to Indicator class Indicator: Adds state property setter Fixes possible loss of data due to type conversion in the latest MTE build Adds Markdown table for MQL/CPP syntax Improves comments for docblock [GH-638] EA: Improves risk management of order price stops [GH-42] IndicatorsTest: Fixes Indi_Drawer Added SerializeStub() method to Chart class. Added more error checks. (#629)
kenorb
added a commit
that referenced
this pull request
Jul 2, 2022
* tag 'v2.011': Indicators: Adds Indicator source type and mode to constructor's argument. Moves indicator data related methods to IndicatorData Indicator: Moves GetValuePrice() to IndicatorData Splits IndicatorParams struct into IndicatorDataParams Refactors IndicatorData class to be inherited by Indicator class Refs #337 New week detection. Added check if it's the first day of the week (which is Monday in MQL). Previously we only checked if current day of the week has changed. CPP: Removes EnumToString Corrects broken links Moves Deal enums to Deal.enum.h Indicators: Moves resetting handle on change to Indicator class Indicator: Adds state property setter Fixes possible loss of data due to type conversion in the latest MTE build Adds Markdown table for MQL/CPP syntax Improves comments for docblock [GH-638] EA: Improves risk management of order price stops [GH-42] IndicatorsTest: Fixes Indi_Drawer Added SerializeStub() method to Chart class. Added more error checks. (#629)
kenorb
added a commit
that referenced
this pull request
Jul 2, 2022
* tag 'v2.011': Indicators: Adds Indicator source type and mode to constructor's argument. Moves indicator data related methods to IndicatorData Indicator: Moves GetValuePrice() to IndicatorData Splits IndicatorParams struct into IndicatorDataParams Refactors IndicatorData class to be inherited by Indicator class Refs #337 New week detection. Added check if it's the first day of the week (which is Monday in MQL). Previously we only checked if current day of the week has changed. CPP: Removes EnumToString Corrects broken links Moves Deal enums to Deal.enum.h Indicators: Moves resetting handle on change to Indicator class Indicator: Adds state property setter Fixes possible loss of data due to type conversion in the latest MTE build Adds Markdown table for MQL/CPP syntax Improves comments for docblock [GH-638] EA: Improves risk management of order price stops [GH-42] IndicatorsTest: Fixes Indi_Drawer Added SerializeStub() method to Chart class. Added more error checks. (#629)
kenorb
added a commit
that referenced
this pull request
Jul 2, 2022
* tag 'v2.011': Indicators: Adds Indicator source type and mode to constructor's argument. Moves indicator data related methods to IndicatorData Indicator: Moves GetValuePrice() to IndicatorData Splits IndicatorParams struct into IndicatorDataParams Refactors IndicatorData class to be inherited by Indicator class Refs #337 New week detection. Added check if it's the first day of the week (which is Monday in MQL). Previously we only checked if current day of the week has changed. CPP: Removes EnumToString Corrects broken links Moves Deal enums to Deal.enum.h Indicators: Moves resetting handle on change to Indicator class Indicator: Adds state property setter Fixes possible loss of data due to type conversion in the latest MTE build Adds Markdown table for MQL/CPP syntax Improves comments for docblock [GH-638] EA: Improves risk management of order price stops [GH-42] IndicatorsTest: Fixes Indi_Drawer Added SerializeStub() method to Chart class. Added more error checks. (#629)
kenorb
added a commit
that referenced
this pull request
Jul 3, 2022
* tag 'v2.011': Fixes timeframe handling Indicators: Adds Indicator source type and mode to constructor's argument. Moves indicator data related methods to IndicatorData Indicator: Moves GetValuePrice() to IndicatorData Splits IndicatorParams struct into IndicatorDataParams Refactors IndicatorData class to be inherited by Indicator class Refs #337 New week detection. Added check if it's the first day of the week (which is Monday in MQL). Previously we only checked if current day of the week has changed. CPP: Removes EnumToString Corrects broken links Moves Deal enums to Deal.enum.h Indicators: Moves resetting handle on change to Indicator class Indicator: Adds state property setter Fixes possible loss of data due to type conversion in the latest MTE build Adds Markdown table for MQL/CPP syntax Adds CONTRIBUTING.md file Adds Twitter badge Improves comments for docblock [GH-638] EA: Improves risk management of order price stops [GH-42] IndicatorsTest: Fixes Indi_Drawer Added SerializeStub() method to Chart class. Added more error checks. (#629)
kenorb
added a commit
that referenced
this pull request
Jul 3, 2022
* tag 'v2.011': Fixes timeframe handling Indicators: Adds Indicator source type and mode to constructor's argument. Moves indicator data related methods to IndicatorData Indicator: Moves GetValuePrice() to IndicatorData Splits IndicatorParams struct into IndicatorDataParams Refactors IndicatorData class to be inherited by Indicator class Refs #337 New week detection. Added check if it's the first day of the week (which is Monday in MQL). Previously we only checked if current day of the week has changed. CPP: Removes EnumToString Corrects broken links Moves Deal enums to Deal.enum.h Indicators: Moves resetting handle on change to Indicator class Indicator: Adds state property setter Fixes possible loss of data due to type conversion in the latest MTE build Adds Markdown table for MQL/CPP syntax Adds CONTRIBUTING.md file Adds Twitter badge Improves comments for docblock [GH-638] EA: Improves risk management of order price stops [GH-42] IndicatorsTest: Fixes Indi_Drawer Added SerializeStub() method to Chart class. Added more error checks. (#629)
kenorb
pushed a commit
that referenced
this pull request
Jun 17, 2023
kenorb
added a commit
that referenced
this pull request
Jun 24, 2023
* v3.003-dev: Indi_ADXW: Fixes logic for SetCustomIndicatorName() ADXW: Renames variables to avoid global conflicts Cherry-pick: Added SerializeStub() method to Chart class. Added more error checks. (#629)
kenorb
added a commit
that referenced
this pull request
Jun 24, 2023
* v3.004-dev: Indicators: Renames some variables to avoid global variable conflict Indi_ADXW: Fixes logic for SetCustomIndicatorName() ADXW: Renames variables to avoid global conflicts Indi_ADXW: Fixes logic for SetCustomIndicatorName() ADXW: Renames variables to avoid global conflicts Cherry-pick: Added SerializeStub() method to Chart class. Added more error checks. (#629)
kenorb
added a commit
that referenced
this pull request
Apr 28, 2024
* origin/v3.003-dev: (93 commits) Cherry-pick: Added SerializeStub() method to Chart class. Added more error checks. (#629) IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge remote-tracking branch 'origin/dev-indi-no-chart4' into v3.003-dev IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge tag 'v3.001' into dev-indi-no-chart4 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Disables Indi_Price for MQL4 due to failure GHA: Sets BtYears to 2021 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Reenables more indicators for testing IndicatorsTest: Reenables indicators for testing Trade: Reenables CalcLotSize() Indi_ZigZag: Fixes indicator path for MQL4 GHA: Test: Sets BtDays to 4-8 to avoid time limits Merge tag 'v3.000' into dev-indi-no-chart4 Indicators: Fixes potential issues with OnIndicator mode Indi_AppliedPrice: Fixes infinite loop when run on indicator Indi_Ichimoku: Shift 2nd and 3rd buffer by senkou_span_shift bars [GH-656] Indicator: GetEntryAlter: Fixes issue with shift GHA: Changes back BtDays to 4-8 ...
kenorb
added a commit
that referenced
this pull request
Apr 28, 2024
* origin/v3.003-dev: (93 commits) Cherry-pick: Added SerializeStub() method to Chart class. Added more error checks. (#629) IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge remote-tracking branch 'origin/dev-indi-no-chart4' into v3.003-dev IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge tag 'v3.001' into dev-indi-no-chart4 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Disables Indi_Price for MQL4 due to failure GHA: Sets BtYears to 2021 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Reenables more indicators for testing IndicatorsTest: Reenables indicators for testing Trade: Reenables CalcLotSize() Indi_ZigZag: Fixes indicator path for MQL4 GHA: Test: Sets BtDays to 4-8 to avoid time limits Merge tag 'v3.000' into dev-indi-no-chart4 Indicators: Fixes potential issues with OnIndicator mode Indi_AppliedPrice: Fixes infinite loop when run on indicator Indi_Ichimoku: Shift 2nd and 3rd buffer by senkou_span_shift bars [GH-656] Indicator: GetEntryAlter: Fixes issue with shift GHA: Changes back BtDays to 4-8 ...
kenorb
added a commit
that referenced
this pull request
Apr 28, 2024
* origin/v3.003-dev: (93 commits) Cherry-pick: Added SerializeStub() method to Chart class. Added more error checks. (#629) IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge remote-tracking branch 'origin/dev-indi-no-chart4' into v3.003-dev IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge tag 'v3.001' into dev-indi-no-chart4 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Disables Indi_Price for MQL4 due to failure GHA: Sets BtYears to 2021 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Reenables more indicators for testing IndicatorsTest: Reenables indicators for testing Trade: Reenables CalcLotSize() Indi_ZigZag: Fixes indicator path for MQL4 GHA: Test: Sets BtDays to 4-8 to avoid time limits Merge tag 'v3.000' into dev-indi-no-chart4 Indicators: Fixes potential issues with OnIndicator mode Indi_AppliedPrice: Fixes infinite loop when run on indicator Indi_Ichimoku: Shift 2nd and 3rd buffer by senkou_span_shift bars [GH-656] Indicator: GetEntryAlter: Fixes issue with shift GHA: Changes back BtDays to 4-8 ...
kenorb
added a commit
that referenced
this pull request
Apr 28, 2024
* origin/v3.003-dev: (93 commits) Cherry-pick: Added SerializeStub() method to Chart class. Added more error checks. (#629) IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge remote-tracking branch 'origin/dev-indi-no-chart4' into v3.003-dev IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge tag 'v3.001' into dev-indi-no-chart4 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Disables Indi_Price for MQL4 due to failure GHA: Sets BtYears to 2021 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Reenables more indicators for testing IndicatorsTest: Reenables indicators for testing Trade: Reenables CalcLotSize() Indi_ZigZag: Fixes indicator path for MQL4 GHA: Test: Sets BtDays to 4-8 to avoid time limits Merge tag 'v3.000' into dev-indi-no-chart4 Indicators: Fixes potential issues with OnIndicator mode Indi_AppliedPrice: Fixes infinite loop when run on indicator Indi_Ichimoku: Shift 2nd and 3rd buffer by senkou_span_shift bars [GH-656] Indicator: GetEntryAlter: Fixes issue with shift GHA: Changes back BtDays to 4-8 ...
kenorb
added a commit
that referenced
this pull request
Apr 28, 2024
* origin/v3.003-dev: (93 commits) Cherry-pick: Added SerializeStub() method to Chart class. Added more error checks. (#629) IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge remote-tracking branch 'origin/dev-indi-no-chart4' into v3.003-dev IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge tag 'v3.001' into dev-indi-no-chart4 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Disables Indi_Price for MQL4 due to failure GHA: Sets BtYears to 2021 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Reenables more indicators for testing IndicatorsTest: Reenables indicators for testing Trade: Reenables CalcLotSize() Indi_ZigZag: Fixes indicator path for MQL4 GHA: Test: Sets BtDays to 4-8 to avoid time limits Merge tag 'v3.000' into dev-indi-no-chart4 Indicators: Fixes potential issues with OnIndicator mode Indi_AppliedPrice: Fixes infinite loop when run on indicator Indi_Ichimoku: Shift 2nd and 3rd buffer by senkou_span_shift bars [GH-656] Indicator: GetEntryAlter: Fixes issue with shift GHA: Changes back BtDays to 4-8 ...
kenorb
added a commit
that referenced
this pull request
Apr 28, 2024
* origin/v3.003-dev: (93 commits) Cherry-pick: Added SerializeStub() method to Chart class. Added more error checks. (#629) IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge remote-tracking branch 'origin/dev-indi-no-chart4' into v3.003-dev IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge tag 'v3.001' into dev-indi-no-chart4 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Disables Indi_Price for MQL4 due to failure GHA: Sets BtYears to 2021 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Reenables more indicators for testing IndicatorsTest: Reenables indicators for testing Trade: Reenables CalcLotSize() Indi_ZigZag: Fixes indicator path for MQL4 GHA: Test: Sets BtDays to 4-8 to avoid time limits Merge tag 'v3.000' into dev-indi-no-chart4 Indicators: Fixes potential issues with OnIndicator mode Indi_AppliedPrice: Fixes infinite loop when run on indicator Indi_Ichimoku: Shift 2nd and 3rd buffer by senkou_span_shift bars [GH-656] Indicator: GetEntryAlter: Fixes issue with shift GHA: Changes back BtDays to 4-8 ...
kenorb
added a commit
that referenced
this pull request
Apr 29, 2024
* origin/v3.003-dev: (93 commits) Cherry-pick: Added SerializeStub() method to Chart class. Added more error checks. (#629) IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge remote-tracking branch 'origin/dev-indi-no-chart4' into v3.003-dev IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge tag 'v3.001' into dev-indi-no-chart4 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Disables Indi_Price for MQL4 due to failure GHA: Sets BtYears to 2021 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Reenables more indicators for testing IndicatorsTest: Reenables indicators for testing Trade: Reenables CalcLotSize() Indi_ZigZag: Fixes indicator path for MQL4 GHA: Test: Sets BtDays to 4-8 to avoid time limits Merge tag 'v3.000' into dev-indi-no-chart4 Indicators: Fixes potential issues with OnIndicator mode Indi_AppliedPrice: Fixes infinite loop when run on indicator Indi_Ichimoku: Shift 2nd and 3rd buffer by senkou_span_shift bars [GH-656] Indicator: GetEntryAlter: Fixes issue with shift GHA: Changes back BtDays to 4-8 ...
kenorb
added a commit
that referenced
this pull request
Apr 29, 2024
* origin/v3.003-dev: (93 commits) Cherry-pick: Added SerializeStub() method to Chart class. Added more error checks. (#629) IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge remote-tracking branch 'origin/dev-indi-no-chart4' into v3.003-dev IndicatorData: IndicatorDataEntryValue: Adds support for datetime type Merge tag 'v3.001' into dev-indi-no-chart4 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Disables Indi_Price for MQL4 due to failure GHA: Sets BtYears to 2021 Strategy/Trade: Reenables previously disabled code IndicatorsTest: Reenables more indicators for testing IndicatorsTest: Reenables indicators for testing Trade: Reenables CalcLotSize() Indi_ZigZag: Fixes indicator path for MQL4 GHA: Test: Sets BtDays to 4-8 to avoid time limits Merge tag 'v3.000' into dev-indi-no-chart4 Indicators: Fixes potential issues with OnIndicator mode Indi_AppliedPrice: Fixes infinite loop when run on indicator Indi_Ichimoku: Shift 2nd and 3rd buffer by senkou_span_shift bars [GH-656] Indicator: GetEntryAlter: Fixes issue with shift GHA: Changes back BtDays to 4-8 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.