Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to income.py + other calibration modules #9

Merged
merged 53 commits into from
Aug 11, 2024

Conversation

jdebacker
Copy link
Contributor

@jdebacker jdebacker commented Aug 3, 2024

This PR updates the various calibration models. The income.py module now includes a functon to match the gini coefficient of the income distribution. It also updates the associated tests for income.py

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 80.45977% with 17 lines in your changes missing coverage. Please review.

Project coverage is 70.75%. Comparing base (956346d) to head (2435444).
Report is 3 commits behind head on main.

Files Patch % Lines
ogphl/income.py 84.21% 6 Missing ⚠️
ogphl/utils.py 25.00% 6 Missing ⚠️
ogphl/macro_params.py 81.81% 4 Missing ⚠️
ogphl/calibrate.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #9       +/-   ##
===========================================
+ Coverage   56.46%   70.75%   +14.29%     
===========================================
  Files          12       12               
  Lines         356      277       -79     
===========================================
- Hits          201      196        -5     
+ Misses        155       81       -74     
Flag Coverage Δ
unittests 70.75% <80.45%> (+14.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdebacker jdebacker changed the title Updates to income.py Updates to income.py + other calibration modules Aug 9, 2024
@jdebacker
Copy link
Contributor Author

@rickecon I've now fixed the demographics plots. This PR is ready for review and merge.

@rickecon
Copy link
Collaborator

@jdebacker. I just submitted a PR to your branch that makes some updates to this PR. I am now just trying to get the current package up on PyPI so it will update automatically.

@rickecon
Copy link
Collaborator

@jdebacker. This looks great. Merging now.

@rickecon rickecon merged commit 7b5c677 into EAPD-DRB:main Aug 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants