Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODON migration changes. #40

Merged
merged 6 commits into from
Nov 2, 2021
Merged

CODON migration changes. #40

merged 6 commits into from
Nov 2, 2021

Conversation

mberacochea
Copy link
Member

Small changes to adjust the pipeline infrastructure to CODON

Small changes to adjust the pipeline infrastructure to CODON
"owltools",
"faselector",
"format_bedfile",
"trimmomatic",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add '.sh' extensions to add_header, awk_tool, format_bedfile and trimmomatic

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll do that :).

Copy link
Contributor

@KateSakharova KateSakharova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Martin, for structuring all these scripts! That makes life easier

Copy link
Contributor

@caballero caballero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are appropriate, clean-up is fine, and adding error exceptions for BASH options is a must, however, the antismash script could be a CWL tool but it is not a priority.

Copy link
Contributor

@caballero caballero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are ok, porting python v2 to v3 should be a separate task in pipeline 5.1

@mberacochea mberacochea merged commit 448fcd7 into master Nov 2, 2021
@mberacochea mberacochea deleted the codon branch November 3, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants