Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EFO CL:0000446 'parathyroid' #376

Closed
paolaroncaglia opened this issue Feb 25, 2019 · 7 comments
Closed

Fix EFO CL:0000446 'parathyroid' #376

paolaroncaglia opened this issue Feb 25, 2019 · 7 comments
Assignees

Comments

@paolaroncaglia
Copy link
Collaborator

In EFO, the term 'parathyroid' is a subclass of 'gland', but is imported from CL and defined (mostly) as a cell type. In CL itself, CL:0000446 is currently labeled as 'chief cell of parathyroid gland'. I'd suggest to rename and rehouse CL:0000446 as a cell-type term (also check its definition citations), and import the relevant UBERON term to represent the gland. The EFO CL term may then be made part_of the EFO UBERON term.

@paolaroncaglia
Copy link
Collaborator Author

I started to look at the definition citations of EFO CL:0000446 'parathyroid':

  • The BTO definition citation BTO:0000997 points to parathyroid gland

  • EHDAA (Human developmental anatomy, abstract version) is now deprecated, so delete the xrefs EHDAA:3870 and EHDAA:3864

To be continued.

@paolaroncaglia
Copy link
Collaborator Author

paolaroncaglia commented Mar 13, 2019

Note that currently EFO CL:0000446 'parathyroid' is used in axioms as if it were the anatomy term (e.g. 'parathyroid gland carcinoma' has disease location 'parathyroid'). This occurs for 5 disease terms at the moment. So the best strategy would be to import UBERON:0001132 'parathyroid gland' and replace EFO CL:0000446 'parathyroid' with it. The 'true' CL term for 'chief cell of parathyroid gland' doesn't seem to be necessary in EFO at the moment, but to avoid any potential trouble due to its removal, we could update its placement (as subclass of EFO CL:0000066 'epithelial cell' and EFO CL:0000151 'secretory cell'), label etc. and make it part_of the UBERON term.

@paolaroncaglia paolaroncaglia self-assigned this Mar 13, 2019
@paolaroncaglia
Copy link
Collaborator Author

@S2Ola
Asking because I know you've been working on UBERON import and terms lately. Would you be able to tell me please if UBERON:0001132 'parathyroid gland' is among the terms that you plan to import in EFO as part of #167? If not I'm happy to import it myself, just making sure we don't duplicate efforts. Thanks.

@zoependlington
Copy link
Collaborator

@paolaroncaglia I do believe it has been imported into EFO 3 through Ola's pipeline.

@S2Ola
Copy link

S2Ola commented Mar 13, 2019

@paolaroncaglia I can confirm that UBERON:0001132 'parathyroid gland' has been imported into EFO3 via my pipeline.
Thanks

@paolaroncaglia
Copy link
Collaborator Author

Thanks @zoependlington and @S2Ola.

@paolaroncaglia
Copy link
Collaborator Author

paolaroncaglia commented May 8, 2019

Note for self:

  • Check "Class usage" tab in Protege for EFO CL:0000446 'parathyroid' and confirm that it is only ever used (erroneously) in axioms where it's meant as an anatomy term instead
  • Check that EFO CL:0000446 'parathyroid' is not required in collaborators' pipelines
  • Import UBERON:0001132 'parathyroid gland' in EFO2 (it's already in EFO3, but not in EFO2)
  • Replace CL:0000446 'parathyroid' with UBERON:0001132 'parathyroid gland' in all axioms where that's necessary. These are: 'parathyroid adenoma', 'p. disease', 'p. gland carcinoma', 'p. hyperplasia', 'secondary hyperparathyroidism'.
  • Obsolete CL:0000446 'parathyroid', with a replaced_by annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants