Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFO 'animal component' vs UBERON 'anatomical structure' #439

Closed
paolaroncaglia opened this issue May 13, 2019 · 3 comments
Closed

EFO 'animal component' vs UBERON 'anatomical structure' #439

paolaroncaglia opened this issue May 13, 2019 · 3 comments
Assignees
Labels

Comments

@paolaroncaglia
Copy link
Collaborator

For #372, and following up on discussion with MONDO editors to try and align on axioms used for diseases, I'll need to add an axiom to 'inflammatory disease' in EFO to mirror the one in MONDO, which is
MONDO:0021166 'inflammatory disease'
equivalent to
disease or disorder and (disease has inflammation site some anatomical structure)
where 'anatomical structure' is UBERON:0000061.
EFO does not have UBERON:0000061 'anatomical structure', but rather EFO:0000787 'animal component', which is parent to all anatomy terms in EFO, but is not used in axioms.
I'm happy to add the axiom I need in EFO as
'inflammatory disease' equivalentTo: disease and (has_inflammation_site some ('animal component' or (part_of some 'animal component')))
but just wanted to double-check with other EFO editors in case we'd want to replace EFO:0000787 'animal component' with the UBERON term. (Asking because there may have been some high-level-term discussion/decision in the past on how to represent anatomy parts in EFO that I'm unaware of.) Note that the UBERON term seems by all means to refer to animals and exclude plants and fungi (http://purl.obolibrary.org/obo/UBERON_0000061).
Going forward with EFO3, wouldn't import/update/alignment processes benefit from that replacement?

@zoependlington
Copy link
Collaborator

In favour of switching with the UBERON term, but should inform users of this in the next release notes/by email.

I'll double check that this is not being used by Annotare or Open Targets.

@paolaroncaglia
Copy link
Collaborator Author

paolaroncaglia commented May 17, 2019

In summary:

  • @zoependlington to check if EFO:0000787 'animal component' is used by Annotare or Open Targets; "It isn’t on the list of terms used by Annotare or on the important terms list from OTAR, so I think it should be okay to go ahead with the obsoletion/replacement". Also, I checked Ontobee and the EFO class isn't used in other ontologies.
  • @paolaroncaglia to import UBERON:0000061 'anatomical structure' and switch from EFO:0000787 'animal component' to UBERON:0000061 'anatomical structure' (i.e. obsolete the EFO term and replace it with the UBERON one - check all Class Usage cases of the EFO term in Protege);
    (I didn't add the many xrefs manually for UBERON:0000061 'anatomical structure' (see http://www.ontobee.org/ontology/UBERON?iri=http://purl.obolibrary.org/obo/UBERON_0000061) because they will be picked up automatically at the next UBERON build.)
  • @zoependlington to inform users of the switch in release notes and release email. Thanks!

@paolaroncaglia
Copy link
Collaborator Author

paolaroncaglia commented May 29, 2019

All done. The next EFO release (June 17th) will be done by @daniwelter , so I'll hand her the last action item above please, i.e.

  • inform users, in release notes and release email, that we switched from using EFO:0000787 'animal component' to using UBERON:0000061 'anatomical structure'.
    I'll assign this ticket to @daniwelter for that. Thanks Dani!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants