-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement querying OLS to update term status #31
Comments
So the way I see it, different kinds of status values require different handling of queries. In particular, OLS queries should:
Please let me know If I missed something. |
Yes, as far as I can see, everything you described is spot on. Actually, originally I only considered the first two cases, but the third one makes sense to include as well |
In essence, I am running OLS updates only for current, awaiting_import and needs_import terms right? Running it for terms that need or await creation is of course problematic, however how should we deal with deleted and obsolete terms, especially those that have been previously mapped to a trait? (The rest will be deleted automatically if they are not picked up in the next ZOOMA query) Do we keep them in the db for reference, or do we delete them? |
Yes, this looks correct to me.
Correct. Since they don't yet have an ID, we can't run OLS for them.
I would say, for provenance/history purposes, let's keep them (so that they can be displayed in the history section) |
Example of an OLS query through JSON API: https://www.ebi.ac.uk/ols/api/ontologies/efo/terms?iri=http://www.ebi.ac.uk/efo/EFO_0000612
This ticket only inlcudes developing the capability to do the query and update the data. Running it automatically or manually will be implemented in other tickets.
The text was updated successfully, but these errors were encountered: