Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design a page to display status & trigger external imports #32

Closed
tskir opened this issue Jun 6, 2020 · 7 comments
Closed

Design a page to display status & trigger external imports #32

tskir opened this issue Jun 6, 2020 · 7 comments
Labels
Kind: UI mockup Issue where work is done in the Figma UI mockup only Priority: High Should be prioritised over other issues Scope: Extra pages

Comments

@tskir
Copy link
Member

tskir commented Jun 6, 2020

There are three external datasources which the app will communicate with:

This page will be essentially an extension of the "External datasources" page which you added in #39. Here are my thoughts on what we could include on that page:

  • Buttons for triggering ClinVar, OLS, ZOOMA imports
  • Configuration variables:
  • Status of import for all three datasources
    • If a particular import is currently in progress, display "In progress"
    • If failed, display "Failed"
    • Otherwise, display the timestamp on when the import was last performed
  • Development options:
    • Button for purging the entire database
    • A number of rows to import from variant_summary.txt.gz (to avoid importing the full set, which may take a lot of time and run over Heroku free limits)
@tskir tskir added Kind: UI mockup Issue where work is done in the Figma UI mockup only Scope: Extra pages labels Jun 6, 2020
@joj0s joj0s added this to To do in Project Progress Jun 7, 2020
@tskir tskir added the Priority: High Should be prioritised over other issues label Jun 18, 2020
@tskir
Copy link
Member Author

tskir commented Jun 18, 2020

Since this page seems handy to have, including for development/debugging purposes, I've raised the priority to high. I have also amended the description of this issue to include some things which can be added to this page.

@joj0s
Copy link
Collaborator

joj0s commented Aug 16, 2020

https://www.figma.com/file/pd5DHJSsldVtJcbp4RvkPb/GSoC-Trait-Mapping-App?node-id=0%3A1
Here is a prototype of this page that I created. I haven't included development button such as "Import dummy data" or "Purge database" since this is supposed to be the production prototype, so I can add those at the top or bottom of the page.

@tcezard
Copy link
Member

tcezard commented Aug 16, 2020

The prototype looks good I have a couple of comments:

  • The section titles are not all placed the same way: Source of mapping suggestion and Source of ontology term information are in line with the logo but Trait name sources is above. Also the first two are lowercase and the third upper case. I would suggest they should all look like Trait name sources
  • I would place the Configure button on the right of the import now button
  • The configure expand arrow should pointing to the right when collapsed and down when expanded

@joj0s
Copy link
Collaborator

joj0s commented Aug 17, 2020

The section titles are not all placed the same way

Regarding this one, the idea is that 'TRAIT NAME SOURCES` is supposed to be a general section title, meaning that more trait name sources can be added later, besides ClinVar, as a list, beneath the 'TRAIT NAME SOURCES' section. I'm not sure if that makes sense? If not, let me know so I can clarify more on that.

Otherwise should I leave it as is, change it, or maybe I should add a similar title for the rest of the data sources, something like 'ONTOLOGY TERM SOURCES' ?

Besides that, the rest of the comments have been addressed and the prototype has been updated.

@joj0s
Copy link
Collaborator

joj0s commented Aug 18, 2020

I have gone through the changes mentioned in yesterday's call, feel free to take a look and tell me your thoughts: https://www.figma.com/file/pd5DHJSsldVtJcbp4RvkPb/GSoC-Trait-Mapping-App?node-id=0%3A1

@joj0s joj0s moved this from In progress to In review in Project Progress Aug 18, 2020
@joj0s
Copy link
Collaborator

joj0s commented Aug 18, 2020

Also I can't seem to find an issue regarding the implementation of this page. I will go ahead an create one.

@tskir
Copy link
Member Author

tskir commented Aug 27, 2020

The mockup looks good to me! I'm going to close this issue, and you may go ahead and proceed with the implementation.

@tskir tskir closed this as completed Aug 27, 2020
Project Progress automation moved this from In review to Done Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind: UI mockup Issue where work is done in the Figma UI mockup only Priority: High Should be prioritised over other issues Scope: Extra pages
Projects
Development

No branches or pull requests

3 participants