-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design a page to display status & trigger external imports #32
Comments
Since this page seems handy to have, including for development/debugging purposes, I've raised the priority to high. I have also amended the description of this issue to include some things which can be added to this page. |
https://www.figma.com/file/pd5DHJSsldVtJcbp4RvkPb/GSoC-Trait-Mapping-App?node-id=0%3A1 |
The prototype looks good I have a couple of comments:
|
Regarding this one, the idea is that 'TRAIT NAME SOURCES` is supposed to be a general section title, meaning that more trait name sources can be added later, besides ClinVar, as a list, beneath the 'TRAIT NAME SOURCES' section. I'm not sure if that makes sense? If not, let me know so I can clarify more on that. Otherwise should I leave it as is, change it, or maybe I should add a similar title for the rest of the data sources, something like 'ONTOLOGY TERM SOURCES' ? Besides that, the rest of the comments have been addressed and the prototype has been updated. |
I have gone through the changes mentioned in yesterday's call, feel free to take a look and tell me your thoughts: https://www.figma.com/file/pd5DHJSsldVtJcbp4RvkPb/GSoC-Trait-Mapping-App?node-id=0%3A1 |
Also I can't seem to find an issue regarding the implementation of this page. I will go ahead an create one. |
The mockup looks good to me! I'm going to close this issue, and you may go ahead and proceed with the implementation. |
There are three external datasources which the app will communicate with:
This page will be essentially an extension of the "External datasources" page which you added in #39. Here are my thoughts on what we could include on that page:
variant_summary.txt.gz
(to avoid importing the full set, which may take a lot of time and run over Heroku free limits)The text was updated successfully, but these errors were encountered: