Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change find method in case history action #3206

Closed
rlgreen91 opened this issue Sep 29, 2019 · 3 comments · Fixed by #3208
Closed

Change find method in case history action #3206

rlgreen91 opened this issue Sep 29, 2019 · 3 comments · Fixed by #3208
Labels
good first issue hacktoberfest quick fix refactoring For refactoring that may or may not address technical debt

Comments

@rlgreen91
Copy link
Contributor

In the history action in the cases controller, change the find method from find_by_slug to find. This should also allow you to remove the check for this_case.blank? in the conditional.

@rlgreen91 rlgreen91 added quick fix hacktoberfest good first issue refactoring For refactoring that may or may not address technical debt labels Sep 29, 2019
@birtony
Copy link
Contributor

birtony commented Sep 29, 2019

Hey, I would be happy to do that!

@rlgreen91
Copy link
Contributor Author

@birtony Sounds great! Please feel free to assign it to yourself. As a quick note, I don't think this will count for Hacktoberfest until October, so I'll probably hold off review until then so you can get your point.

@birtony
Copy link
Contributor

birtony commented Sep 29, 2019

@rlgreen91 alright, thank you!

rlgreen91 referenced this issue Oct 2, 2019
Changed find method & removed conditional statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue hacktoberfest quick fix refactoring For refactoring that may or may not address technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants