Memberの物理削除対応 #2496
Merged
Memberの物理削除対応 #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihiro-adachi
force-pushed
the
physical-delete-member
branch
from
6768407
to
75a4afd
Compare
kiy0taka
reviewed
Sep 12, 2017
| ->setRank(0); | ||
|
|
||
| $em->persist($Member); | ||
| $em->remove($Member); |
There was a problem hiding this comment.
呼び出し元のMemberController#deleteでForeignKeyConstraintViolationExceptionの対応が必要。
There was a problem hiding this comment.
@kiy0taka 一応\Exceptionでcatchしているので、ハンドリングは行われるはずですが、厳密にしたほうがよいですか？
There was a problem hiding this comment.
把握しました。catch問題はまた別で考えましょう。
kiy0taka
approved these changes
Sep 12, 2017
| ->setRank(0); | ||
|
|
||
| $em->persist($Member); | ||
| $em->remove($Member); |
There was a problem hiding this comment.
把握しました。catch問題はまた別で考えましょう。
added 4 commits
September 15, 2017 09:55
chihiro-adachi
force-pushed
the
physical-delete-member
branch
from
75a4afd
to
cd39c15
Compare
kiy0taka
approved these changes
Sep 15, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
方針(Policy)
テスト（Test)