Paymentの物理削除対応 #2499
Merged
Paymentの物理削除対応 #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiy0taka
changed the base branch from
experimental/3.1
to
experimental/physical-delete
src/Eccube/Entity/Payment.php
Outdated
| @@ -38,6 +38,16 @@ | |||
| class Payment extends \Eccube\Entity\AbstractEntity | |||
| { | |||
| /** | |||
| * @var int | |||
| */ | |||
| const ACTIVE = 0; | |||
There was a problem hiding this comment.
@kiy0taka ACTIVEとOBSOLETEは使ってない？
Merged
okazy
added a commit
to okazy/ec-cube
that referenced
this pull request
Jul 21, 2020
論理削除はなくなったので不適切なコメントを削除 refs EC-CUBE#2499
okazy
added a commit
to okazy/ec-cube
that referenced
this pull request
Jul 21, 2020
論理削除はなくなったので不適切なコメントを削除 refs EC-CUBE#2499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
以下を参考にコメントを作成してください。
概要(Overview・Refs Issue)
del_flgの廃止visibleプロパティによるフロントでの表示/非表示対応関連
#2490
#2314