Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.scrutinizser.yml の修正 #3236

Merged
merged 34 commits into from
Aug 1, 2018

Conversation

nanasess
Copy link
Contributor

概要(Overview・Refs Issue)

  • Scrutinizer を動くようにする

方針(Policy)

  • php-cs-fixer と極力同じ設定を .scrutinizer.yml で設定する
  • Travis CI での Inspection はやめ、 Scrutinizer Auto-fixer を使用する

実装に関する補足(Appendix)

  • Scrutinizer の repository config は使用しないようにし、極力 .scrutinizer.yml で設定するように修正
  • Reviewer が Scrutinizer の結果を見て、問題があるようであれば Scrutinizer Auto-fixer でパッチを作成する

テスト(Test)

  • Scrutinizer が正常終了することを確認
  • この Pull Request は、 Scrutinizer と php-cs-fixer 両方で正常終了するよう対応済み

相談(Discussion)

  • @EC-CUBE/lockon issues と Scrutinizer の連携設定をお願いします

@okazy okazy added this to the 3.n.0 milestone Jun 27, 2018
@ryo-endo ryo-endo merged commit 4846476 into EC-CUBE:experimental/sf Aug 1, 2018
@nanasess nanasess deleted the modify-scrutinizeryml branch December 3, 2018 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants