Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12商品詳細から来た時は商品詳細画面へ戻す #3318

Merged
merged 1 commit into from Aug 11, 2018

Conversation

oywc410
Copy link
Contributor

@oywc410 oywc410 commented Jul 12, 2018

No description provided.

@okazy okazy added this to the 3.n.0 milestone Jul 13, 2018
@ryo-endo
Copy link
Contributor

動作確認はOK。
商品詳細、商品一覧それぞれに戻れます。

@okazy okazy self-requested a review July 17, 2018 10:08
@okazy
Copy link
Contributor

okazy commented Jul 17, 2018

動作、コード確認しました。
この実装で問題はないんですが、パラメータに違うルーティングを渡してやると他のページに遷移できたり、ルーティングがないとエラーになったりと少し心配な点はあります。
具体的にいいい方法は思いつかないのですが、何かアイデアがあればご意見をいただきたいです。

@okazy okazy added the question Further information is requested label Jul 17, 2018
@ryo-endo ryo-endo changed the base branch from experimental/sf to 4.0 August 6, 2018 11:16
@ryo-endo ryo-endo added this to To do in 4.0 BugHunt Aug 7, 2018
@ryo-endo ryo-endo moved this from To do to In progress (遠藤が確認中) in 4.0 BugHunt Aug 7, 2018
@ryo-endo ryo-endo moved this from In progress (一次確認中) to In review (開発チームのレビュー必要) in 4.0 BugHunt Aug 7, 2018
@okazy
Copy link
Contributor

okazy commented Aug 11, 2018

こちら一旦取り込ませていただき、懸念点については別途issueを立てさせていただきます。

@okazy okazy merged commit fca7cd7 into EC-CUBE:4.0 Aug 11, 2018
4.0 BugHunt automation moved this from In review (開発チームのレビュー必要) to Done Aug 11, 2018
@okazy okazy added enhancement 機能追加 and removed Status: needs-review question Further information is requested labels Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 機能追加
Projects
No open projects
4.0 BugHunt
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants