Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer --no-dev で動作しないのを修正 #3479

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Aug 7, 2018

概要(Overview・Refs Issue)

php-cs-fixer は Entity proxy 生成で使用されているため、 --no-dev オプションでも動作する必要がある

方針(Policy)

php-cs-fixer を composer.json の require に入れる

テスト(Test)

composer install --no-dev で proxy が生成されるのを確認

@kiy0taka kiy0taka merged commit fa5497e into EC-CUBE:4.0 Aug 7, 2018
@kiy0taka kiy0taka added this to the 4.0 milestone Aug 7, 2018
@nanasess nanasess deleted the fix-no-dev branch December 3, 2018 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants