管理画面商品一覧で在庫なしの絞り込み結果修正 #4422
Merged
管理画面商品一覧で在庫なしの絞り込み結果修正 #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
テストを通すために最新の4.0ブランチに追従
okazy
approved these changes
Mar 4, 2020
|
ありがとうございます。マージしました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
#4421
現在在庫があるにも関わらず、在庫なしの状態で規格初期化をすると在庫なしの検索結果に出続ける、というのは良くないかと考えての修正希望になります。
実装に関する補足(Appendix)
tests/Eccube/Tests/Web/Admin/AdminControllerProductNonStockTest.phpは特に問題なし
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目