タグ管理画面にエンティティ拡張の自動出力を追加 #4432
Merged
タグ管理画面にエンティティ拡張の自動出力を追加 #4432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okazy
added
affected:admin_template
genzouw
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
タグ管理画面にエンティティ拡張の自動出力を追加する
方針(Policy)
タグの登録フォームにauto_render => trueで要素を追加しても画面に表示されないため、カテゴリ等と同様に自動で表示されるようにする
実装に関する補足(Appendix)
カテゴリではauto_renderのフォームは縦並びで表示されるが、元々のHTML構造をなるべく変えないようにするため横並びで表示
テスト（Test)
Eccube\Form\Type\Admin\ProductTagに対するExtensionでauto_renderされる要素を追加して確認
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目