New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle に依存するプラグインの E2Eテスト追加 #4632
Merged
kiy0taka
merged 21 commits into
EC-CUBE:experimental/plugin_bundle
from
nanasess:bundle-plugin-testing
Jul 30, 2020
Merged
Bundle に依存するプラグインの E2Eテスト追加 #4632
kiy0taka
merged 21 commits into
EC-CUBE:experimental/plugin_bundle
from
nanasess:bundle-plugin-testing
Jul 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
プラグイン削除時のMappingExceptionを回避
> Symfony\Component\Debug\Exception\ContextErrorException: Notice: Undefined index: > entity-namespaces in /home/runner/work/ec-cube/ec-cube/src/Eccube/Service/PluginContext.php:87
This reverts commit b487937.
This reverts commit b487937.
PHP 7.1.3を超えるバージョンを必要とするプラグインを安全にインストールできるようにする
nanasess
changed the title
[WIP] Bundle に依存するプラグインの E2Eテスト追加
Bundle に依存するプラグインの E2Eテスト追加
Jul 27, 2020
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
以下の PR が必要
方針(Policy)
#4625 のE2Eテストを追加
実装に関する補足(Appendix)
テスト(Test)
PHP 7.3.20-1+ubuntu18.04.1+deb.sury.org+1
というPHPバージョンを返すため composer がエラーを吐いているのが原因の模様。相談(Discussion)
composer.json でPHP 7.1.3を超えるバージョンを必要とするプラグインを安全にインストールできるようにする #4634 で対応いただきましたconfig.platform.php: 7.1.3
を指定していても、 require PHP7.2.0 or higher な bundle がインストールできてしまうマイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目