Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DockerでGDでjpegやwebpを扱える様にDokerfileを変更 #4902

Merged
merged 1 commit into from Mar 4, 2021

Conversation

tao-s
Copy link
Contributor

@tao-s tao-s commented Feb 5, 2021

概要(Overview・Refs Issue)

リサイズやフォーマット変換機能を使う場合に開発環境でテストしずらいので追加
ref: #4896 #4900 #4898

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更
  • フックポイントの呼び出しタイミングの変更
  • フックポイントのパラメータの削除・データ型の変更
  • twigファイルに渡しているパラメータの削除・データ型の変更
  • Serviceクラスの公開関数の、引数の削除・データ型の変更
  • 入出力ファイル(CSVなど)のフォーマット変更

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@chihiro-adachi chihiro-adachi added this to the 4.1 milestone Feb 9, 2021
@chihiro-adachi chihiro-adachi added the enhancement 機能追加 label Feb 9, 2021
@shyim
Copy link

shyim commented Feb 25, 2021

Maybe consider rewriting it with https://github.com/mlocati/docker-php-extension-installer

@okazy okazy self-assigned this Mar 2, 2021
@okazy
Copy link
Contributor

okazy commented Mar 2, 2021

GD の WebP Support が有効になっていることを確認しました!

変更前

image

変更後

image

@okazy okazy merged commit 44333e9 into EC-CUBE:4.1-feature Mar 4, 2021
@okazy
Copy link
Contributor

okazy commented Mar 4, 2021

ありがとうございます!マージしました。

@tao-s
Copy link
Contributor Author

tao-s commented Mar 8, 2021

Maybe consider rewriting it with

@okazy できれば @shyim さんが勧めてくれたように追々もう少し軽量なコンテナにしたいですね。

@shyim
Copy link

shyim commented Mar 8, 2021

Maybe look also into docker multi stage. It reduces to have node / composer in the repository. (Also maybe alpine base as its very small then) https://github.com/FriendsOfShopware/packages/blob/live/Dockerfile#L3

(I don't speak japanese commented random here lol)

@tao-s
Copy link
Contributor Author

tao-s commented Mar 8, 2021

@shyim Thank you for the information. I'll refer the docker file for EC-CUBE.
BTW, I surprised to you wrote comments. You are great committer of other open source software. Maybe EC-CUBE is far from your business.
Why did you get attention to EC-CUBE?

@shyim
Copy link

shyim commented Mar 8, 2021

Was on Github Trending as I work also for an ecommerce company was interesting so see how things get solved here. Also very interested into japanese culture. curiosity :)

@tao-s
Copy link
Contributor Author

tao-s commented Mar 8, 2021

I see. Ya, I checked Shopware, it's very interesting for me.
I'll try to translate it to Japanese when I have a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants