新着商品・新着情報のRSSフィード機能 #4908
Merged
新着商品・新着情報のRSSフィード機能 #4908
+193
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiy0taka
reviewed
Mar 9, 2021
| <title>{{ BaseInfo.shop_name }} 新着情報</title> | ||
| <description>{{ BaseInfo.shop_name }} 新着情報</description> | ||
| <link>{{ url('homepage') }}</link> | ||
| <lastBuildDate>{{ "now" | date(constant('DATE_RFC822')) }}</lastBuildDate> |
There was a problem hiding this comment.
lastBuildDate | The last time the content of the channel changed.
https://validator.w3.org/feed/docs/rss2.html#optionalChannelElements
なので、お知らせの最終更新日時がいいかと思います。(商品情報も同様)
kiy0taka
suggested changes
Mar 9, 2021
kiy0taka
approved these changes
Mar 11, 2021
kiy0taka
suggested changes
Mar 11, 2021
| <atom:link href="{{ url('rss_feed_for_news') }}" rel="self"/> | ||
|
|
||
| {% for article in news %} | ||
| <item> | ||
| <title>{{ article.title }}</title> | ||
| <title>{{ article.title }} | ||
| </title> |
There was a problem hiding this comment.
@kiy0taka すいません、修正しました。
kiy0taka
approved these changes
Mar 12, 2021
Closed
This was referenced Mar 17, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
新着商品と、新着情報(ニュース) のRSSフィードを出力する機能を実装しました。
関連issue
方針(Policy)
実装に関する補足(Appendix)
テスト（Test)
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目