Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer Update #5048

Merged
merged 1 commit into from Jun 23, 2021
Merged

Composer Update #5048

merged 1 commit into from Jun 23, 2021

Conversation

chihiro-adachi
Copy link
Contributor

@chihiro-adachi chihiro-adachi commented May 27, 2021

概要(Overview・Refs Issue)

Symfony Components更新

$ composer update 'symfony/*'
Package operations: 2 installs, 56 updates, 0 removals
  - Updating symfony/flex (v1.8.4 => v1.13.3): Loading from cache
  - Updating symfony/asset (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/class-loader (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/css-selector (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/debug (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/polyfill-mbstring (v1.17.1 => v1.22.1): Loading from cache
  - Updating symfony/var-dumper (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/polyfill-ctype (v1.17.1 => v1.22.1): Loading from cache
  - Updating symfony/twig-bridge (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/http-foundation (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/event-dispatcher (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/http-kernel (v3.4.42 => v3.4.49): Loading from cache
  - Updating symfony/filesystem (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/config (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/twig-bundle (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/routing (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/web-profiler-bundle (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/stopwatch (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/profiler-pack (v1.0.4 => v1.0.5): Loading from cache
  - Updating symfony/monolog-bridge (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/dependency-injection (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/monolog-bundle (v3.5.0 => v3.6.0): Loading from cache
  - Updating symfony/debug-bundle (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/debug-pack (v1.0.8 => v1.0.9): Loading from cache
  - Updating symfony/doctrine-bridge (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/dotenv (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/polyfill-apcu (v1.17.1 => v1.22.1): Loading from cache
  - Updating symfony/cache (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/expression-language (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/inflector (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/property-access (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/options-resolver (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/intl (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/polyfill-intl-icu (v1.17.1 => v1.22.1): Loading from cache
  - Updating symfony/form (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/finder (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/framework-bundle (v3.4.42 => v3.4.47): Loading from cache
  - Installing symfony/deprecation-contracts (v2.4.0): Loading from cache
  - Updating symfony/console (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/maker-bundle (v1.19.0 => v1.29.2): Loading from cache
  - Updating symfony/proxy-manager-bridge (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/security (v3.4.48 => v3.4.49): Loading from cache
  - Updating symfony/security-bundle (v3.4.42 => v3.4.48): Loading from cache
  - Updating symfony/serializer (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/templating (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/translation (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/validator (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/process (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/web-server-bundle (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/workflow (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/yaml (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/dom-crawler (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/browser-kit (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/phpunit-bridge (v3.4.42 => v3.4.47): Loading from cache
  - Updating symfony/polyfill-iconv (v1.17.1 => v1.22.1): Loading from cache
  - Updating symfony/polyfill-php72 (v1.17.0 => v1.22.1): Loading from cache
  - Installing symfony/polyfill-intl-normalizer (v1.22.1): Loading from cache
  - Updating symfony/polyfill-intl-idn (v1.17.1 => v1.22.1): Loading from cache

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更
  • フックポイントの呼び出しタイミングの変更
  • フックポイントのパラメータの削除・データ型の変更
  • twigファイルに渡しているパラメータの削除・データ型の変更
  • Serviceクラスの公開関数の、引数の削除・データ型の変更
  • 入出力ファイル(CSVなど)のフォーマット変更

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@chihiro-adachi chihiro-adachi added this to the 4.0.6 milestone May 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #5048 (d836399) into 4.0 (7d8d59a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                4.0    #5048   +/-   ##
=========================================
  Coverage     76.19%   76.19%           
  Complexity     6124     6124           
=========================================
  Files           437      437           
  Lines         20744    20744           
=========================================
  Hits          15805    15805           
  Misses         4939     4939           
Flag Coverage Δ
tests 76.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Eccube/Form/Type/Shopping/ShippingType.php 94.40% <0.00%> (-1.60%) ⬇️
...be/Service/PurchaseFlow/Processor/TaxProcessor.php 83.33% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8d59a...d836399. Read the comment docs.

@okazy okazy added the dependencies Pull requests that update a dependency file label May 27, 2021
Copy link
Contributor

@okazy okazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自動テストも通っているので問題ないと思います。

@chihiro-adachi chihiro-adachi modified the milestones: 4.0.6, 4.0.x Jun 23, 2021
@okazy okazy merged commit 6ec8440 into EC-CUBE:4.0 Jun 23, 2021
@okazy
Copy link
Contributor

okazy commented Jun 23, 2021

ありがとうございます、マージしました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Status: ready-for-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants