Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php-cs-fixer を実行 #5105

Merged
merged 1 commit into from Aug 13, 2021
Merged

php-cs-fixer を実行 #5105

merged 1 commit into from Aug 13, 2021

Conversation

okazy
Copy link
Contributor

@okazy okazy commented Aug 12, 2021

概要(Overview・Refs Issue)

php-cs-fixer を実行しました。

vendor/bin/php-cs-fixer fix --config=.php_cs.dist

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

念の為、目視で動作に影響しそうな変更がないことを確認しています。

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更
  • フックポイントの呼び出しタイミングの変更
  • フックポイントのパラメータの削除・データ型の変更
  • twigファイルに渡しているパラメータの削除・データ型の変更
  • Serviceクラスの公開関数の、引数の削除・データ型の変更
  • 入出力ファイル(CSVなど)のフォーマット変更

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@okazy okazy added the improvement 機能改善 label Aug 12, 2021
@okazy okazy added this to the 4.1 milestone Aug 12, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #5105 (03c7277) into 4.1 (dba64e7) will not change coverage.
The diff coverage is 10.52%.

Impacted file tree graph

@@           Coverage Diff           @@
##              4.1    #5105   +/-   ##
=======================================
  Coverage   68.08%   68.08%           
=======================================
  Files         457      457           
  Lines       24972    24972           
=======================================
  Hits        17002    17002           
  Misses       7970     7970           
Flag Coverage Δ
tests 68.08% <10.52%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/Controller/Admin/Product/CsvImportController.php 55.56% <ø> (ø)
...r/Admin/Setting/System/TwoFactorAuthController.php 0.00% <0.00%> (ø)
...rc/Eccube/Controller/Install/InstallController.php 12.50% <0.00%> (ø)
src/Eccube/Controller/InstallPluginController.php 0.00% <ø> (ø)
src/Eccube/Controller/SitemapController.php 83.78% <ø> (ø)
src/Eccube/EventListener/MaintenanceListener.php 55.55% <ø> (ø)
...Eccube/Form/EventListener/HTMLPurifierListener.php 100.00% <ø> (ø)
...e/Form/Extension/HTMLPurifierTextTypeExtension.php 84.61% <ø> (ø)
src/Eccube/Form/Type/Admin/TwoFactorAuthType.php 0.00% <0.00%> (ø)
src/Eccube/Service/SystemService.php 34.84% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba64e7...03c7277. Read the comment docs.

@chihiro-adachi chihiro-adachi merged commit 3a04811 into EC-CUBE:4.1 Aug 13, 2021
@chihiro-adachi
Copy link
Contributor

@okazy ありがとうございます、確認しました

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement 機能改善
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants