New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
管理画面URLを「cart」にした場合、カート画面への遷移時に管理画面が表示される #5343
Conversation
@@ -142,6 +155,24 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
; | |||
} | |||
|
|||
private function getRouteCollection() | |||
{ | |||
$fountRoutesUrlList = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$frontRoutesUrlList のtypoでしょうか?(違っていたら無視してください)
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## 4.2 #5343 +/- ##
============================================
- Coverage 82.54% 82.53% -0.01%
- Complexity 6401 6408 +7
============================================
Files 475 475
Lines 25734 25759 +25
============================================
+ Hits 21241 21260 +19
- Misses 4493 4499 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* フロントURL一覧を取得 | ||
* @return string | ||
*/ | ||
private function getRouteCollection(): string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
helpやproductsといったパスはエラーにできますか?
@watarukashii |
@chihiro-adachi products や cart といった文言のみの登録はエラーとし、 |
@@ -80,6 +89,9 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
new Assert\Regex([ | |||
'pattern' => '/\A\w+\z/', | |||
]), | |||
new Assert\Regex([ | |||
'pattern' => "/\A^(?!($routes)$).*\z/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@watarukashii
こちらの変数 $routes が未定義変数となっております。修正をお願い致します。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
いや、これは @dotani1111 さんのrebase処理が引き起こしてるっぽいですね。
こちらで修正いたします。
@watarukashii |
レビューの指摘事項、こちらで修正いたしました。 |
@@ -76,6 +76,7 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
$denyHosts = implode("\n", $denyHosts); | |||
|
|||
$routes = $this->getRouteCollection(); | |||
dump($routes); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@watarukashii
dumpの削除をお願いします。
@shinya |
@chihiro-adachi |
概要(Overview・Refs Issue)
#4710
管理画面URLをcartにした場合、カートへの遷移ができない
cartに限らず、フロントのパスと同じパスを設定すると発生します
方針(Policy)
RouterInterface をもとにフロントのURLを抽出の上、比較
テスト(Test)
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目