New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
フロント画面へのIPアクセス制限の実装 #5858
Merged
chihiro-adachi
merged 12 commits into
EC-CUBE:4.2
from
shinya:feature/addition_IP_access_allow_list
Dec 7, 2022
Merged
フロント画面へのIPアクセス制限の実装 #5858
chihiro-adachi
merged 12 commits into
EC-CUBE:4.2
from
shinya:feature/addition_IP_access_allow_list
Dec 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihiro-adachi
requested changes
Nov 9, 2022
Codecov Report
@@ Coverage Diff @@
## 4.2 #5858 +/- ##
============================================
+ Coverage 78.78% 78.80% +0.02%
- Complexity 6298 6307 +9
============================================
Files 470 470
Lines 21132 21174 +42
============================================
+ Hits 16649 16687 +38
- Misses 4483 4487 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chihiro-adachi
requested changes
Nov 17, 2022
chihiro-adachi
approved these changes
Nov 28, 2022
chihiro-adachi
requested changes
Dec 1, 2022
chihiro-adachi
approved these changes
Dec 5, 2022
@shinya |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
下記のIssueで取り上げられていた、フロント画面へのIPアクセス制御を実装。
#5779
方針(Policy)
従来から実装されていた、管理画面へのアクセス制限を踏襲し実装。
実装に関する補足(Appendix)
管理画面へのアクセス制限を踏襲したものの、
複数の範囲の制限が需要として考えられることから
サブネットマスクでの管理を可能としている点が少し実装ロジックが異なります。
(管理画面ではビットマスクによる指定ができる)
例: 192.168.56.1/32
テスト(Test)
Unitテスト、E2Eテスト共に更新済みです
相談(Discussion)
EC-CUBEの仕様に乗っ取れているか。
実装箇所が間違っていないか。
マイナーバージョン互換性保持のための制限事項チェックリスト
※以下、確認中です
レビュワー確認項目