GitHub Actions の dockerbuild で push する際に PHP7.4 のイメージを使用していたのを修正 #5952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
GitHub Actions の dockerbuild で push する際に PHP7.4 のイメージを使用していたのを修正。
docker-compose.yml で PHP8.1 のイメージを指定した場合でも、内部的には PHP7.4 のイメージを使用していた。
https://github.com/EC-CUBE/ec-cube/actions/runs/4182333338/jobs/7245295456#step:13:151
方針(Policy)
docker push の際にも build-args を指定する
実装に関する補足(Appendix)
テスト(Test)
PHP8.1のイメージを使用して docker push しているのを確認
https://github.com/nanasess/ec-cube/actions/runs/4239579074/jobs/7367768929#step:13:150
https://github.com/nanasess/ec-cube/actions/runs/4239579074/jobs/7367768864#step:13:147
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目