Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODE REVIEW: DOCUMENTATION #55

Open
2 of 10 tasks
bramiozo opened this issue Oct 5, 2017 · 2 comments
Open
2 of 10 tasks

CODE REVIEW: DOCUMENTATION #55

bramiozo opened this issue Oct 5, 2017 · 2 comments
Assignees

Comments

@bramiozo
Copy link

bramiozo commented Oct 5, 2017

Documentation is a prerequisite for using, developing and reviewing the program. Here are some things to check for.

  • (yes) Is there a description of the purpose of the program or library? Perhaps handy to place the latest version of the ec2mor3 paper in the code lib?
  • (yes) Are detailed requirements listed?
  • (no) Are requirements ranked according to MoSCoW? (must-haves, should-haves, could-haves, would-haves)
  • (not the purpose/use) Is the use and function of third-party libraries documented?
  • (there is no schematic overview) Is the structure/architecture of the program documented? Perhaps nice to add a simple diagram next in your Design section of the readme?
  • [x ] (yes) Is there an installation manual?
  • (there are examples but there is no user manual) Is there a user manual?
  • (no) Is there documentation on how to contribute?
  • (no) Including how to submit changes
  • (no) Including how to document your changes
  • (no) Are function/classes documented following PEP8? For small function, just state the purpose
	```Returns bla
	Description:
		blabla
	Input variables:
		varname, vartype; description
	Output:
		varname, vartype, description
	```
@goord goord self-assigned this Nov 7, 2018
@zklaus
Copy link

zklaus commented Jan 25, 2019

@bramiozo This looks like some very useful ideas! Given that the development has progressed almost to the finishing line, I think it would make sense to focus a bit more on the user documentation.
Do you think you could help with that?

@treerink
Copy link
Collaborator

Note that @goord is also planning to write a describing paper (with us), and in that process there will be additional effort on all level documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants