New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Land masked IFS variables require masked regridding #671
Comments
The list of
|
I think you are forgetting lai, this is quite important if you want to compute a global mean 0 values over the ocean will dillute the mean. Or maybe I misunderstand what you mean? |
I checked that |
Accidentally I mentioned the wrong issue in three commit messages (therefore the commits were not auto attached to this issue):
|
Sorry for coming in late in the discussion. I am a little bit puzzled about the "masked regridding" of IFS variables. The raw IFS output is on a reduced Gauss grid, and this is then mapped to a regular Gauss grid with |
We divide the variable first by the mask expression , e.g. |
Am I wrong in my understanding that all lpjg output is also affected by a similar bug, because the non-land points all have values of 0 and the "cdo remapycon" remapping produces wrong values over the coastline, since there is no masking done ? |
Thanks @goord for the explanation. Pretty dangerous to divide by 0 to get missing values in my humble opinion. Another point: are we sure that @etiennesky : LPJG output fields are not necessarily affected by the bug because they are saved on an unstructered grid that is not remapped with |
The division is what we found as cdo recommendation for masked regridding. See updates -the diff figures- on the ec-earth issue 922. |
If we fear a similar bug in the LPJG land masked regridding in the cmorisation, please open a separate issue for that. Closing this one. |
In 314d909 one varlist for the CMIP historical and one other for the ScenarioMIP ssp's (both AOGCM) are added with which the incorrect variables of #671 & #684 can be recmorised for those who still have the raw IFS EC-Earth3 data. In addition the fx variables are added in this varlist because of #667. |
See also ec-earth issue 922.
While working on #664 we discovered that land/soil IFS variables which (often or always) have a land mask, require masked regridding. The masked regridding for these variables is possible, but was not implemented in
ece2cmor3
until now. This means that many or all coastal points for these variables have incorrect values, as partly sea points with improper values have been used in the interpolation.In #664 (comment) the similar problem for the outside-cmor case of
tos
on the atmosphere grid case was encountered but with the sea mask.An additional complication is that with the current
ece2cmor3
code the addition of the masking of monthly or yearly variables causes the BUG that these variable get dismissed, when the used mask is anfx
variable which is for the land masking the case withgrib code 172
.We plan to improve this masking for a next
ece2cmor3
release, as this simply gives clear better results.We realize that this issue also concerns the cmorised and published CMIP6 data. How to cope with this and whether we want to create errata or even want to correct published data for this should be discussed on the ec-earth portal. Correcting the data might be a hard task, as we believe this is only possible with from raw data.
The text was updated successfully, but these errors were encountered: