New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug snow mass err #248
Merged
Merged
Bug snow mass err #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jmccreight
commented
Oct 28, 2023
•
edited
edited
- Closes 'PRMSSoilzone' object has no attribute '_adjust_parameters' #249
- Ensures mass balance for snow on CONUS introducing new (rare) coditions for through_rain when rain but not snow on a snowpack is subsequently evaporated off during the time step. some of this work updates PRMS code slightly
- Removed machine epsilons in favor of slightly larger thesholds which are identical in python and fortran
- Went over consistency of thresholds between PRMS and PWS
- Introduces a more rare mass balance error (4 times*locations) in 2 years
…tion of all pkwater_equiv not included in through_rain cases
… precision epsilon. solve by enforcing in PRMS (and in PWS)
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #248 +/- ##
===========================================
+ Coverage 78.31% 78.93% +0.61%
===========================================
Files 51 51
Lines 6706 6694 -12
===========================================
+ Hits 5252 5284 +32
+ Misses 1454 1410 -44
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
…v is <= DNEARZERO
…htly larger than informal definitions
…an up and add some missing but currently uused functionality in prms_snow init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.