Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Dev FAQ Pinned Memory #3437

Merged
merged 6 commits into from Oct 3, 2022
Merged

Doc: Dev FAQ Pinned Memory #3437

merged 6 commits into from Oct 3, 2022

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Sep 29, 2022

Since I spoke to two devs in 24hrs about the topic, let us document it.

@ax3l ax3l added backend: cuda Specific to CUDA execution (GPUs) component: documentation Docs, readme and manual backend: hip Specific to ROCm execution (GPUs) backend: dpc++ Specific to DPC++/SYCL execution (CPUs/GPUs) labels Sep 29, 2022
@ax3l ax3l marked this pull request as ready for review September 29, 2022 17:04
@ax3l
Doc: Dev FAQ Pinned Memory
4d561ea 
Since I spoke to two devs in 24hrs about the topic, let us document
it.
@ax3l @RTSandberg
Apply suggestions from code review
1c30baa 
Co-authored-by: Ryan Sandberg <RSandberg@lbl.gov>
@ax3l
Copy link
Member Author

ax3l commented Sep 29, 2022

Thx for the review @RTSandberg :)

@ax3l @dpgrote
Wording feedback from Dave
fd5a5ca 
Co-authored-by: David Grote <dpgrote@lbl.gov>
dpgrote
dpgrote approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@dpgrote dpgrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Though, maybe add a comment that pinned memory works on all of the supported flavors of GPU (is that correct?).

ax3l
ax3l commented Oct 3, 2022
View reviewed changes
Docs/source/developers/faq.rst Outdated Show resolved Hide resolved
Docs/source/developers/faq.rst Outdated Show resolved Hide resolved
@ax3l ax3l enabled auto-merge (squash) October 3, 2022 18:51
@ax3l ax3l disabled auto-merge October 3, 2022 18:51
@ax3l ax3l enabled auto-merge (squash) October 3, 2022 18:51
@ax3l ax3l merged commit a0eea6d into ECP-WarpX:development Oct 3, 2022
@ax3l ax3l deleted the doc-faq-pinned branch October 13, 2022 22:31
dpgrote added a commit to dpgrote/WarpX that referenced this pull request Nov 22, 2022
@ax3l @RTSandberg @dpgrote
Doc: Dev FAQ Pinned Memory (ECP-WarpX#3437)
28e0afa 
* Doc: Dev FAQ Pinned Memory

Since I spoke to two devs in 24hrs about the topic, let us document
it.

Co-authored-by: Ryan Sandberg <RSandberg@lbl.gov>
Co-authored-by: David Grote <dpgrote@lbl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgrote dpgrote dpgrote approved these changes

@RTSandberg RTSandberg RTSandberg approved these changes

@WeiqunZhang WeiqunZhang Awaiting requested review from WeiqunZhang

@Thierry992 Thierry992 Awaiting requested review from Thierry992

Assignees

@WeiqunZhang WeiqunZhang

Labels
backend: cuda Specific to CUDA execution (GPUs) backend: dpc++ Specific to DPC++/SYCL execution (CPUs/GPUs) backend: hip Specific to ROCm execution (GPUs) component: documentation Docs, readme and manual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ax3l @dpgrote @RTSandberg @WeiqunZhang