Obtain exact point of contact of Particles with EB #4560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… case of one particle and EB
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ions from the branch bisection
Make it work for GPU
RemiLehe
reviewed
Feb 12, 2024
RemiLehe
reviewed
Feb 12, 2024
RemiLehe
reviewed
Feb 12, 2024
RemiLehe
reviewed
Feb 12, 2024
RemiLehe
requested changes
Feb 12, 2024
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
for more information, see https://pre-commit.ci
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies how particles are saved in the boundary buffer: it now saves the particle at the exact point of contact of the particle trajectory with the surface of the EB. The previous code was saving the position on the EB which was closest to the position of the particle after it moved through the EB, which does not necessarily correspond to the point of contact.
This PR also adds automated tests in 3D only (when issue #4676 will be fixed, a test in RZ will be added)