Revert "Update Particle Container to Pure SoA (#3850)" #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 94ae119.
ax3l
added
bug
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Jan 30, 2024
Transition to new, purely SoA particle containers. This was originally merged in ECP-WarpX#3850 and reverted in ECP-WarpX#4652, since we discovered issues loosing particles & laser particles on GPU.
4 tasks
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Jan 31, 2024
Transition to new, purely SoA particle containers. This was originally merged in ECP-WarpX#3850 and reverted in ECP-WarpX#4652, since we discovered issues loosing particles & laser particles on GPU.
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Feb 2, 2024
Transition to new, purely SoA particle containers. This was originally merged in ECP-WarpX#3850 and reverted in ECP-WarpX#4652, since we discovered issues loosing particles & laser particles on GPU.
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Feb 2, 2024
Transition to new, purely SoA particle containers. This was originally merged in ECP-WarpX#3850 and reverted in ECP-WarpX#4652, since we discovered issues loosing particles & laser particles on GPU.
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Feb 2, 2024
Transition to new, purely SoA particle containers. This was originally merged in ECP-WarpX#3850 and reverted in ECP-WarpX#4652, since we discovered issues loosing particles & laser particles on GPU.
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Feb 2, 2024
Transition to new, purely SoA particle containers. This was originally merged in ECP-WarpX#3850 and reverted in ECP-WarpX#4652, since we discovered issues loosing particles & laser particles on GPU.
RemiLehe
pushed a commit
that referenced
this pull request
Feb 2, 2024
* AMReX & pyAMReX: Latest `development` More pure SoA and id handling goodness. * Particle Container to Pure SoA Again Transition to new, purely SoA particle containers. This was originally merged in #3850 and reverted in #4652, since we discovered issues loosing particles & laser particles on GPU. * Modernize `idcpu` Treatment - faster: less emitted operations, no jumps - cheaper: less used registers - safer: no read-before-write warnings - cooler: no explanation needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 94ae119.
On GPU, we issues initializing laser particles and keeping periodic boundary particles.
Reverting #3850 for now.