Update of the time saved for scraped particles on the boundaries #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Revathi Jambunathan <41089244+RevathiJambunathan@users.noreply.github.com>
Co-authored-by: Revathi Jambunathan <41089244+RevathiJambunathan@users.noreply.github.com>
RemiLehe
requested changes
Feb 22, 2024
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
This was referenced Feb 22, 2024
RemiLehe
approved these changes
Feb 22, 2024
auto-merge was automatically disabled
February 22, 2024 23:55
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of the PR #4695
From the buffer of scraped particles, we can have access now to:
-the integer "stepScraped" which corresponds to the PIC iterations just before each particle hits boundaries (EB + regular boundaries)
-The real "deltaTimeScraped" which corresponds to the fraction of time between the time associated with the last step and the exact time when each particle hits an EB (for the regular boundaries, it is equal to 0 --> we still need to calculate it). This real is between 0 and dt.