Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort: First Party Modules #4902

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Apr 29, 2024

Declare amrex, picmistandard and pywarpx our first party modules, even if they are not installed. This resolves inconsistencies when sorting imports in developer or remote runs (pre-commit.com CI).

@ax3l ax3l added bug Something isn't working component: tests Tests and CI component: Python Python layer labels Apr 29, 2024
Declare `amrex` and `pywarpx` our first party modules, even if they
are not installed. This resolves inconsistencies when sorting imports
in developer or remote runs (pre-commit.com CI).
Copy link
Member

@lucafedeli88 lucafedeli88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@lucafedeli88 lucafedeli88 merged commit 2aee638 into ECP-WarpX:development Apr 29, 2024
45 checks passed
@ax3l ax3l deleted the fix-isort-firstp branch April 30, 2024 19:56
Haavaan pushed a commit to Haavaan/WarpX that referenced this pull request Jun 5, 2024
* `isort`: First Party Modules

Declare `amrex` and `pywarpx` our first party modules, even if they
are not installed. This resolves inconsistencies when sorting imports
in developer or remote runs (pre-commit.com CI).

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: Python Python layer component: tests Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants