[WIP] Enable sort_particles_for_deposition on AMD by default #4946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSinn
changed the title
ax3l
added
Performance optimization
backend: hip
RemiLehe
changed the title
|
@n01r I think that you volunteered to perform benchmarks with this PR. Any update? |
|
@RemiLehe, sorry no updates yet but yes I volunteered! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I tweaked
amrex::SortParticlesForDepositionto work better on MI250X (AMReX-Codes/amrex#3925). In my testing with HiPACE++, it now makes the deposition faster compared to usingSortParticlesByCellon MI250X, where previouslySortParticlesForDepositionwas worse for smaller numbers of particles per cell.