-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IO: Parallel Particle ASCII Output #109
Merged
ax3l
merged 5 commits into
ECP-WarpX:development
from
ax3l:topic-parallelParticleASCIIdiags
Apr 11, 2022
Merged
IO: Parallel Particle ASCII Output #109
ax3l
merged 5 commits into
ECP-WarpX:development
from
ax3l:topic-parallelParticleASCIIdiags
Apr 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2022
Closed
3a65c22
to
8087229
Compare
atmyers
reviewed
Apr 11, 2022
atmyers
reviewed
Apr 11, 2022
This is the same hack as in `amrex::ParticleContainer::WriteAsciiFile`: This will obviously not scale and also has the wrong assumption that MPI-sync is the same as parallel FS sync (it is not).
8087229
to
0998e32
Compare
268a6aa
to
6c89d25
Compare
OpenMP: Intentionally overwrite Environment control for now
I also added a first MPI-parallel test (#103) now:
I think we need to remove some hacks in |
atmyers
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write one file per MPI rank (and pot. OpenMP thread).
Update post-processing logic to process this.
Needed for #103
To Do:
X-ref: