Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests/Python: add multipole python test #211

Merged
merged 5 commits into from
Aug 26, 2022
Merged

Tests/Python: add multipole python test #211

merged 5 commits into from
Aug 26, 2022

Conversation

RTSandberg
Copy link
Member

  • add Python run script
  • add run script to example documentation
  • add automated CTest

@RTSandberg RTSandberg changed the title Test add multipole python test Tests/Python: add multipole python test Aug 23, 2022
@RTSandberg RTSandberg mentioned this pull request Aug 23, 2022
Closed
n01r
n01r reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@n01r n01r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment change, then it also looks good, thank you! :)

examples/multipole/README.rst Outdated Show resolved Hide resolved
cemitch99
cemitch99 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good me me, thanks.

@ax3l ax3l self-assigned this Aug 25, 2022
@ax3l ax3l added component: tests examples, tests and benchmarks component: python Python bindings labels Aug 25, 2022
ax3l
ax3l reviewed Aug 25, 2022
View reviewed changes
examples/CMakeLists.txt Outdated Show resolved Hide resolved
examples/multipole/README.rst Show resolved Hide resolved
examples/multipole/run_multipole.py Outdated Show resolved Hide resolved
@RTSandberg @ax3l
Apply suggestions from code review
216e9c0 
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
@ax3l ax3l merged commit c4f1f97 into ECP-WarpX:development Aug 26, 2022
@RTSandberg RTSandberg deleted the test-addMultipolePythonTest branch May 18, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n01r n01r n01r left review comments

@ax3l ax3l ax3l approved these changes

@cemitch99 cemitch99 cemitch99 approved these changes

Assignees

@ax3l ax3l

Labels
component: python Python bindings component: tests examples, tests and benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RTSandberg @ax3l @n01r @cemitch99