-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Element: Line #335
New Element: Line #335
Conversation
Add line elements to the IOTA lattice example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
second_half.reverse = true | ||
second_half.elements = dra1 qa1 dra2 qa2 dra3 qa3 dra4 qa4 dra5 | ||
edge30 sbend30 edge30 drb1 qb1 drb2 qb2 drb2 qb3 | ||
drb3 dnll drb3 qb4 drb2 qb5 drb2 qb6 drb4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point it would be ideal to modify this to allow something like second_half.elements = first_half.elements, to avoid repetition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WeiqunZhang I am a bit unsure here: does the AMReX ParamParse or the AMReX parser support this already?
second_half.elements = first_half.elements
Each are arrays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks for adding this useful capability.
Add a new
<element_name>.type = line
to the inputs elements options.Did not add this to Python, since we already use standard Python lists to build lines.
In sync with WarpX:
Close #284