New Element: Line #335
Merged
New Element: Line #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2023
Add line elements to the IOTA lattice example.
cemitch99
reviewed
Apr 12, 2023
| second_half.reverse = true | ||
| second_half.elements = dra1 qa1 dra2 qa2 dra3 qa3 dra4 qa4 dra5 | ||
| edge30 sbend30 edge30 drb1 qb1 drb2 qb2 drb2 qb3 | ||
| drb3 dnll drb3 qb4 drb2 qb5 drb2 qb6 drb4 |
There was a problem hiding this comment.
At some point it would be ideal to modify this to allow something like second_half.elements = first_half.elements, to avoid repetition.
There was a problem hiding this comment.
@WeiqunZhang I am a bit unsure here: does the AMReX ParamParse or the AMReX parser support this already?
second_half.elements = first_half.elements
Each are arrays.
cemitch99
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
<element_name>.type = lineto the inputs elements options.Did not add this to Python, since we already use standard Python lists to build lines.
In sync with WarpX:
Close #284