Correction to Zeuthen chicane input #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified the initial beam size in the IOTA lens benchmark example. - Added 2 benchmarks of 3D space charge for initial testing. - Add documentation for 2 benchmarks with space charge. - Add a benchmark example with space charge and periodic s-dependent focusing. - Added an s-dependent example using a Kurth beam without space charge. - Modified tolerance for IOTA lens benchmark example. Reduced tolerance to account for smaller initial beam size and improved preservation of invariants of motion. - Modified tolerances of space charge examples to allow CI tests to pass when space charge is not active. - Modified tolerance for space charge examples. These should fail unless space charge is turned on.
Selected numerical values for amr.n_cell, lattice.nslice, and geometry.prob_relative.
for more information, see https://pre-commit.ci
Not part of this pr
Not part of this PR.
n01r
reviewed
Apr 26, 2024
There was a problem hiding this comment.
Thanks, @cemitch99!
I have just a little comment about a comment string. :)
P.S.: Your PR still shows 8 commits but I think it is really only one commit and the rest is already in development, right? You could rebase to development and then the commit structure will be simpler. :)
Update lb comment.
ax3l
reviewed
Apr 26, 2024
Comment on lines
+29
to
+37
| sbend1.ds = 0.500194828041958 # projected length 0.5 m, angle 2.77 deg | ||
| sbend1.rc = -10.3462283686195526 | ||
|
|
||
| drift1.type = drift | ||
| drift1.ds = 5.0058489435 # projected length 5 m | ||
|
|
||
| sbend2.type = sbend | ||
| sbend2.ds = 0.50037 # projected length 0.5 m, angle 2.77 deg | ||
| sbend2.rc = 10.35 | ||
| sbend2.ds = 0.500194828041958 # projected length 0.5 m, angle 2.77 deg | ||
| sbend2.rc = 10.3462283686195526 |
There was a problem hiding this comment.
If you want, we could use user-defined constants and the parser here to make it a bit clearer how those (projected) parameters come to play.
ax3l
reviewed
Apr 26, 2024
| @@ -48,17 +48,18 @@ | |||
|
|
|||
| # design the accelerator lattice | |||
| ns = 25 # number of slices per ds in the element | |||
| rc = 10.35 # bend radius (meters) | |||
| rc = 10.3462283686195526 # bend radius (meters) | |||
There was a problem hiding this comment.
We could use Python math here to make it a bit clearer how those (projected) parameters come to play.
ax3l
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A correction to the bend parameters appearing in the Zeuthen chicane benchmark example, as pointed out by @zhangli28 here.
This change is small, and does not visibly affect the reduced_diagnostics output. No update to the CI analysis script is required.