Replace {push,pop}Region with ScopedRegion #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwitaechong
force-pushed
the
scoped_region
branch
from
599a3c7
to
8e11703
Compare
streeve
requested changes
Feb 5, 2024
streeve
changed the title
kwitaechong
force-pushed
the
scoped_region
branch
from
8e11703
to
de2cb9f
Compare
kwitaechong
changed the title
|
@kwitaechong this can be rebased on master |
kwitaechong
force-pushed
the
scoped_region
branch
from
de2cb9f
to
b5ed3ea
Compare
streeve
approved these changes
Feb 19, 2024
|
Ignoring unrelated jenkins failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace pushRegion/popRegion with ScopedRegion for cases where the function returns early, etc.
closes #736