Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added prefix argument to Grid writeTimeStep #744

Merged
merged 2 commits into from Apr 11, 2024
Merged

Added prefix argument to Grid writeTimeStep #744

merged 2 commits into from Apr 11, 2024

Conversation

DavidJoy8
Copy link
Contributor

Grid's BovWriter currently does not allow the user any control over the filename. This change makes it work the same as the HDF5 particle output.

streeve
streeve requested changes Apr 1, 2024
View reviewed changes
Copy link
Member

@streeve streeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - need to fix the test though

grid/unit_test/tstBovWriter.hpp Outdated Show resolved Hide resolved
grid/unit_test/tstBovWriter.hpp Outdated Show resolved Hide resolved
@streeve
Copy link
Member

streeve commented Apr 11, 2024

Failures unrelated

@streeve streeve merged commit 5c243b1 into ECP-copa:master Apr 11, 2024
32 of 34 checks passed
@DavidJoy8 DavidJoy8 mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streeve streeve streeve requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DavidJoy8 @streeve