Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup: sparse halo range policy #753

Merged
merged 1 commit into from
May 13, 2024

Conversation

streeve
Copy link
Member

@streeve streeve commented May 9, 2024

Breaking with Kokkos develop:

no known conversion for argument 1 from 
'Kokkos::RangePolicy<Kokkos::OpenMP>::member_type' {aka 'long unsigned int'} to 
'const Kokkos::Impl::AtomicDataElement<Kokkos::ViewTraits<int [2], Kokkos::HostSpace, Kokkos::MemoryTraits<4> > >&'```

@streeve streeve requested a review from dalg24 May 9, 2024 17:38
@streeve streeve self-assigned this May 9, 2024
@dalg24
Copy link
Collaborator

dalg24 commented May 9, 2024

<kokkos>/include/Kokkos_ExecPolicy.hpp:272:14: error: no matching conversion for static_cast from 'member_type' (aka 'unsigned long') to 'Kokkos::Impl::AtomicDataElement<Kokkos::ViewTraits<int[2], Kokkos::HostSpace, Kokkos::MemoryTraits<4>>>'
    warn |= (static_cast<IndexType>(static_cast<member_type>(bound)) != bound);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@ldh4 this is interesting.

https://github.com/kokkos/kokkos/blob/506da184f0aa8af9fbbca5bccd8c500b81865af5/core/src/Kokkos_ExecPolicy.hpp#L126-L131
In the constraint we ensure convertibility from the user-provided argument to the policy index type but in the precondition check we do a roundtrip conversion and here it turns out the reverse conversion is not possible.

@streeve streeve force-pushed the fixup_sparsehalo_rangepolicy branch from bbc793d to df90345 Compare May 13, 2024 17:58
@streeve
Copy link
Member Author

streeve commented May 13, 2024

Ignoring jenkins HIP/SYCL failures

@streeve streeve merged commit 6be5fb5 into ECP-copa:master May 13, 2024
33 of 34 checks passed
@streeve streeve deleted the fixup_sparsehalo_rangepolicy branch May 13, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants