Update ExaMiniMD for Kokkos v3.0 promotion #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 22, 2019 15:13
…tion, remove this usage.
….cpp:162:42: warning: more '%' conversions than data arguments [-Wformat]).
…ve been reorganized to be consistent with Kokkos::View. ExaMiniMD not currently using Arg3Type, which if provided corresponds to the MemoryTraits. Because the implementation is not using variadic templates, order of template arguments matters. For now simply passing the default value. May want to use this differently?
…>::team_size_max(Functor) changes to a member function of the team policy. The previous variant didn't take all necessary information into account and could potentially result in invalid answers. NOTE: the league and team size arguments passed to the TeamPolicy may warrant inspection (force_types/force_snap_neigh_impl.h:183), e.g., perhaps use team_scratch_size & thread_scratch_size?
stanmoore1
requested changes
Jul 23, 2019
stanmoore1
approved these changes
Jul 25, 2019
|
@alanphumphrey will this build with Kokkos 2.9.0, or do I need to wait for Kokkos 3.0? Thanks for the help. |
|
@stanmoore1, yes this will compile with Kokkos v2.9, however you need to explicitly disable support for deprecated code, e.g. set KOKKOS_OPTIONS=disable_deprecated_code. In ExaMiniMD/src/makefile, change line 35 from: KOKKOS_OPTIONS=aggressive_vectorization This is because deprecated code support is ON by default in v2.9. With 3.0 all this support will be removed and my changes will work by default. Happy to help, let me know if you have any other questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates ExaMiniMD for the Kokkos version 3.0 promotion, and works with deprecated code disabled (KOKKOS_OPTIONS= disable_deprecated_code). There will be a complete removal of deprecated code support after the Kokkos version 3.0 release, hence this pull request. Current status and timeline for Kokkos code deprecations is at: https://github.com/kokkos/kokkos/wiki/DeprecationPage
This pull request corresponds to issue #27.
Please note that with this pull request, ExaMiniMD no longer builds with deprecated code enabled (KOKKOS_OPTIONS=enable_deprecated_code), due to the implementation of StaticCrsGraph (Kokkos_StaticCrsGraph.hpp) not using variadic templates (e.g., order of template arguments matters).