Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added convenience function and testing for plotting validation residu… #95

Merged
merged 2 commits into from
Mar 16, 2020
Merged

Added convenience function and testing for plotting validation residu… #95

merged 2 commits into from
Mar 16, 2020

Conversation

BGerwe
Copy link
Collaborator

@BGerwe BGerwe commented Mar 16, 2020

…als. Updated validation example to use this function. Addresses #74

@BGerwe
Added convenience function and testing for plotting validation residu…
bf93865 
…als. Updated validation example to use this function.
@BGerwe BGerwe requested review from mdmurbach and nealde March 16, 2020 18:30
@coveralls
Copy link

coveralls commented Mar 16, 2020 •
edited

Pull Request Test Coverage Report for Build 303

  • 26 of 26 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 92.169%
Totals Coverage Status
Change from base Build 300: 0.4%
Covered Lines: 918
Relevant Lines: 996
💛 - Coveralls

mdmurbach
mdmurbach approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@mdmurbach mdmurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only minor suggestion would be to allow the y_limits to be set via a keyword argument (with a default).

impedance/visualization.py Outdated Show resolved Hide resolved
@BGerwe BGerwe merged commit 91921df into ECSHackWeek:master Mar 16, 2020
@BGerwe BGerwe deleted the feature/residuals-plot branch March 16, 2020 18:47
@BGerwe BGerwe mentioned this pull request Mar 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdmurbach mdmurbach mdmurbach approved these changes

@nealde nealde Awaiting requested review from nealde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BGerwe @coveralls @mdmurbach